From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH libdrm 01/10] tests: Split helpers into library Date: Mon, 14 Dec 2015 09:12:00 +0100 Message-ID: <20151214081200.GA10055@ulmo.nvidia.com> References: <1449682668-22487-1-git-send-email-thierry.reding@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0501737880==" Return-path: Received: from mail-pf0-f169.google.com (mail-pf0-f169.google.com [209.85.192.169]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5A1C889FE6 for ; Mon, 14 Dec 2015 00:12:05 -0800 (PST) Received: by pff63 with SMTP id 63so7423098pff.2 for ; Mon, 14 Dec 2015 00:12:04 -0800 (PST) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Emil Velikov Cc: Hyungwon Hwang , ML dri-devel List-Id: dri-devel@lists.freedesktop.org --===============0501737880== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="jRHKVT23PllUwdXP" Content-Disposition: inline --jRHKVT23PllUwdXP Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Dec 12, 2015 at 03:26:09PM +0000, Emil Velikov wrote: > Hi Thierry, all, >=20 > On 9 December 2015 at 17:37, Thierry Reding wr= ote: > > From: Thierry Reding > > > > Some of the helpers, such as the pattern drawing helpers or the format > > lookup helpers, have potential to be reused. Move them into a separate > > library to make it easier to share them. > > > > Acked-by: Laurent Pinchart > > Signed-off-by: Thierry Reding > > --- > > CleanSpec.mk | 1 + > > configure.ac | 1 + > > tests/Makefile.am | 2 +- > > tests/modeprint/Makefile.am | 1 + > > tests/modeprint/modeprint.c | 2 +- > > tests/modetest/Android.mk | 1 + > > tests/modetest/Makefile.am | 8 +- > > tests/modetest/buffers.c | 961 +-----------------------------------= -------- > > tests/modetest/buffers.h | 12 +- > > tests/modetest/cursor.c | 4 +- > > tests/modetest/modetest.c | 25 +- > > tests/proptest/Makefile.am | 4 +- > > tests/proptest/proptest.c | 3 +- > > tests/util/Android.mk | 39 ++ > > tests/util/Makefile.am | 13 + > > tests/util/Makefile.sources | 6 + > > tests/util/common.h | 33 ++ > > tests/util/format.c | 120 ++++++ > > tests/util/format.h | 65 +++ > > tests/util/pattern.c | 870 ++++++++++++++++++++++++++++++++++++= +++ > > tests/util/pattern.h | 39 ++ > > tests/vbltest/Makefile.am | 1 + > > tests/vbltest/vbltest.c | 2 +- > > 23 files changed, 1223 insertions(+), 990 deletions(-) > > create mode 100644 tests/util/Android.mk > > create mode 100644 tests/util/Makefile.am > > create mode 100644 tests/util/Makefile.sources > > create mode 100644 tests/util/common.h > > create mode 100644 tests/util/format.c > > create mode 100644 tests/util/format.h > > create mode 100644 tests/util/pattern.c > > create mode 100644 tests/util/pattern.h > > > As mentioned on IRC, although there might be some minor nitpicks I'd > rather the series in those in and fix them later. Mostly to avoid the > long gap until you get the chance to respin things, but also to spare > Tomi (and others) the need to reinvent them :-) I don't mind doing another round if you point out the nitpicks. I'm hopeful that I'll get around to respinning sooner this time. =3D) Thierry --jRHKVT23PllUwdXP Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJWbnnHAAoJEN0jrNd/PrOhTKUP/1vjzWMaK0a0ywXK5LeE/QOr nN1E8jRWnbFfzbxcHCMyeV2QQBTLd1zsxJeITAb/0hrMVutvT8ozI152bvCQCwN0 HIltxiFS7MQ5YkGU0fy4UDI5b0rr9lXGNxNjIdJ1wPkwEgcJrpFaXyHE9rYfDDBV nZRD/K+jZmiVzpAqh1H/+BjzNyA8OFH+LiA5q1YJ3ct4p68KFgME8Yvkmflz8fFC PIrf602TV/HKObg7ceXxlN05dy5200/5tpzClFCYle3pJPUtOSOiTktGzJyTuhiX pfHYrpGr/bKnPzbCF6VNlNvMuRrBlz7EYI+IxvI1aJLQdZLd0OCFBF3WZI/n6iQt EYwTdp5KqIHS3YpTsxrQBBiLesN3wiZ5sy471iIbOBgeVeCBKu/UQGoDyV8Rf3Bc p7VElyi1jtFxgFCEylCIl2bWN3LACpE80u39Zo7pd1ziSWCBaVsVUaswX971ShS4 D8jltiwjeV1AwzeFWyqjqQKaMaSI1bDNLzYEvVXxB0nfAgl1uy6wCPfmOa0VCegc VgA6JZAbJ8JIT81mruMrgSqRsCFUUJJfQuxktie/jtQdMP7tyX2Tu7C8ox6eR8p7 3gD90dDYxeH7Z3lJR6W7JMoyCUjEp50K4ETE0IobiAjHsA5FEnywEwPktPtVQ1nV EiVndJPh7guMp3aqI8EE =EA3m -----END PGP SIGNATURE----- --jRHKVT23PllUwdXP-- --===============0501737880== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK --===============0501737880==--