All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH] doc: announce API change for rte_ether.h
Date: Mon, 14 Dec 2015 09:30:58 -0800	[thread overview]
Message-ID: <20151214093058.2207f569@xeon-e3> (raw)
In-Reply-To: <20151214160025.GA37212@bricha3-MOBL3>


> > FreeBSD
> > -------
> > 
> > struct ether_addr {                                                                                              
> >   u_char octet[ETHER_ADDR_LEN];
> > } __packed;
> > 
> > struct ether_header {
> >   u_char  ether_dhost[ETHER_ADDR_LEN];
> >   u_char  ether_shost[ETHER_ADDR_LEN];
> >   u_short ether_type;
> > } __packed;
> > 
> 
> Unfortunate. While the idea seems good, I think the structures being different
> on the different OS's is a problem that need to be solved before we make such
> a change.

The different BSD variants have different definitions (ie NetBSD different than FreeBSD)

Since the data structures are conformant, the other possiblity
is adding ether_ntoa family prototypes to rte_ether.h

      reply	other threads:[~2015-12-14 17:30 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-10 23:27 [PATCH] doc: announce API change for rte_ether.h Stephen Hemminger
2015-12-11  9:28 ` Panu Matilainen
2015-12-11 16:33   ` Stephen Hemminger
2015-12-14 14:54 ` Thomas Monjalon
2015-12-14 15:30   ` Bruce Richardson
2015-12-14 15:41     ` Thomas Monjalon
2015-12-14 16:00       ` Bruce Richardson
2015-12-14 17:30         ` Stephen Hemminger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151214093058.2207f569@xeon-e3 \
    --to=stephen@networkplumber.org \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.