All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Neutron Soutmun <neo.neutron@gmail.com>
Cc: 20151006012711.GA5372@oxygen.gentoo.org,
	netfilter-devel@vger.kernel.org,
	Mike Frysinger <vapier@gentoo.org>,
	Caroline Tice <cmtice@google.com>
Subject: Re: [PATCH v4] libmnl: Drop the EXPORT_SYMBOL() tags
Date: Mon, 14 Dec 2015 13:37:31 +0100	[thread overview]
Message-ID: <20151214123731.GA26186@salvia> (raw)
In-Reply-To: <CAMQP0snn7nt=iK6Um4doYFPSn1ffTDtUOKi8NBjp=ZCE58EXQw@mail.gmail.com>

Cc'ing everyone that has sent patches to us to address libmnl
compilation problems with clang.

On Sat, Nov 14, 2015 at 07:45:44AM +0700, Neutron Soutmun wrote:
> The initial problem for my proposed patch is the incompatible of
> symbols visibility in gcc and clang
> which libmnl is failed to build from source in clang and it's the one
> of another approaches that pass the build in both gcc and clang.
> 
> I'll test your patch with clang and back to you ASAP.

Did anyone consider going back to the clang community and ask why
EXPORT_SYMBOL() definition is not correct there?

I understand removing this from our libraries is a quick solution, but
I think it would be to get feedback from them to see if it's something
that they can fix there (it would resolve problems for projects a using
similar definition without updating the code).

Let me know, thanks.

  reply	other threads:[~2015-12-14 12:37 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-29 19:07 [PATCH v4] libmnl: Drop the EXPORT_SYMBOL() tags Mike Frysinger
2015-11-01 22:09 ` Jan Engelhardt
2015-11-14  0:45 ` Neutron Soutmun
2015-12-14 12:37   ` Pablo Neira Ayuso [this message]
2015-12-14 17:34     ` Caroline Tice
2015-12-14 17:37       ` Caroline Tice
2015-12-14 19:25       ` Pablo Neira Ayuso
  -- strict thread matches above, loose matches on Subject: below --
2015-10-06  1:27 Neutron Soutmun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151214123731.GA26186@salvia \
    --to=pablo@netfilter.org \
    --cc=20151006012711.GA5372@oxygen.gentoo.org \
    --cc=cmtice@google.com \
    --cc=neo.neutron@gmail.com \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=vapier@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.