All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>,
	intel-gfx@lists.freedesktop.org, Takashi Iwai <tiwai@suse.de>
Subject: Re: [PATCH 1/2] drm/i915: Kill intel_crtc->cursor_bo
Date: Mon, 14 Dec 2015 17:30:01 +0200	[thread overview]
Message-ID: <20151214153001.GR4437@intel.com> (raw)
In-Reply-To: <20151214113223.GP24300@nuc-i3427.alporthouse.com>

On Mon, Dec 14, 2015 at 11:32:23AM +0000, Chris Wilson wrote:
> On Mon, Dec 14, 2015 at 01:16:47PM +0200, ville.syrjala@linux.intel.com wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > 
> > The vma may have been rebound between the last time the cursor was
> > enabled and now, so skipping the cursor gtt offset deduction is not
> > safe unless we would also reset cursor_bo to NULL when disabling the
> > cursor. Just thow cursor_bo to the bin instead since it's lost all
> > other uses thanks to universal plane support.
> 
> You could also mention that since updating the cursor is so slow now
> through the universal-plane support, that a fast path to avoid a few
> writes/checks is also irrelevant.

I can add a note.

At some point we really should start measuring things and try to get
some of the speed back for common stuff like cursor movement and page
flips.

-- 
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2015-12-14 15:30 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-14 11:16 [PATCH 0/2] drm/i915: Fix the invisible cursor syndrome ville.syrjala
2015-12-14 11:16 ` [PATCH 1/2] drm/i915: Kill intel_crtc->cursor_bo ville.syrjala
2015-12-14 11:32   ` Chris Wilson
2015-12-14 15:30     ` Ville Syrjälä [this message]
2015-12-14 15:35   ` [PATCH v2 " ville.syrjala
2015-12-14 15:37     ` Chris Wilson
2015-12-14 11:16 ` [PATCH 2/2] drm/i915: Drop the broken cursor base==0 special casing ville.syrjala
2015-12-14 11:33   ` Chris Wilson
2015-12-14 20:23 ` [PATCH 0/2] drm/i915: Fix the invisible cursor syndrome Ville Syrjälä

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151214153001.GR4437@intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.