From: Brian Norris <computersforpeace@gmail.com>
To: Boris Brezillon <boris.brezillon@free-electrons.com>
Cc: "David Woodhouse" <dwmw2@infradead.org>,
linux-mtd@lists.infradead.org, linux-wireless@vger.kernel.org,
"Rafał Miłecki" <zajec5@gmail.com>
Subject: Re: [PATCH] mtd: nand: bcm47xxnflash: fix bcm47xxnflash_remove()
Date: Mon, 14 Dec 2015 09:30:11 -0800 [thread overview]
Message-ID: <20151214173011.GA15605@localhost> (raw)
In-Reply-To: <1450113250-12036-1-git-send-email-boris.brezillon@free-electrons.com>
On Mon, Dec 14, 2015 at 06:14:10PM +0100, Boris Brezillon wrote:
> bcm47xxnflash_remove() is supposed to unregister the NAND device previously
> registered in bcm47xxnflash_probe(), but the current implementation just
> test for the always NULL ->mtd platform data field (and does not call the
> right function to unregister it).
>
> Kill the useless ->mtd field in struct bcma_nflash, and release the real
> NAND device in bcm47xxnflash_remove().
>
> Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
> Fixes: a5401370c520 ("mtd: prepare place for BCMA NAND flash driver(s)")
> Cc: Rafał Miłecki <zajec5@gmail.com>
> ---
> drivers/mtd/nand/bcm47xxnflash/main.c | 7 ++++---
> include/linux/bcma/bcma_driver_chipcommon.h | 4 ----
> 2 files changed, 4 insertions(+), 7 deletions(-)
Hmm, looks awfully similar...
http://patchwork.ozlabs.org/patch/554164/
next prev parent reply other threads:[~2015-12-14 17:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-14 17:14 [PATCH] mtd: nand: bcm47xxnflash: fix bcm47xxnflash_remove() Boris Brezillon
2015-12-14 17:30 ` Brian Norris [this message]
2015-12-14 17:52 ` Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151214173011.GA15605@localhost \
--to=computersforpeace@gmail.com \
--cc=boris.brezillon@free-electrons.com \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.