All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: xinhui <xinhui.pan@linux.vnet.ibm.com>
Cc: linux-kernel@vger.kernel.org, Jiri Slaby <jslaby@suse.com>,
	dvyukov@google.com, yanmin_zhang@linux.intel.com
Subject: Re: [PATCH] tty/n_gsm.c: fix false positive WARN_ON and do some codes improvement
Date: Mon, 14 Dec 2015 10:55:13 -0800	[thread overview]
Message-ID: <20151214185513.GA19131@kroah.com> (raw)
In-Reply-To: <5655990D.7090300@linux.vnet.ibm.com>

On Wed, Nov 25, 2015 at 07:18:37PM +0800, xinhui wrote:
> From: xinhui <xinhui@linux.vnet.ibm.com>
> 
> If gsm driver fails to activate one mux, and this mux is not stored in
> gsm_mux[], there would be a warning in gsm_cleanup_mux(). Actually this
> is a legal case. So just do a simple check instead of WARN_ON.
> 
> There is one filed gsm->num to store its index of gsm_mux[]. So use
> gsm->num to remove itself from gsm_mux[] instead of the for-loop
> traverse.
> 
> Reported-by: Dmitry Vyukov <dvyukov@google.com>
> Fixes: 5a64096700dc ("tty/n_gsm.c: fix a memory leak in gsmld_open")
> Signed-off-by: Pan Xinhui <xinhui.pan@linux.vnet.ibm.com>

the signed-off-by name has to match your from: name :(

  parent reply	other threads:[~2015-12-14 21:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-25 11:18 [PATCH] tty/n_gsm.c: fix false positive WARN_ON and do some codes improvement xinhui
2015-11-25 11:27 ` xinhui
2015-12-14 18:55 ` Greg Kroah-Hartman [this message]
2015-12-15  5:43   ` Pan Xinhui

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151214185513.GA19131@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=dvyukov@google.com \
    --cc=jslaby@suse.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=xinhui.pan@linux.vnet.ibm.com \
    --cc=yanmin_zhang@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.