From: Dan Carpenter <dan.carpenter@oracle.com>
To: shemminger@osdl.org
Cc: netdev@vger.kernel.org
Subject: re: [PATCH] chelsio: add support for other 10G boards
Date: Mon, 14 Dec 2015 22:58:42 +0300 [thread overview]
Message-ID: <20151214195842.GA20848@mwanda> (raw)
Hello Stephen Hemminger,
The patch f1d3d38af757: "[PATCH] chelsio: add support for other 10G
boards" from Dec 1, 2006, leads to the following static checker
warning:
drivers/net/ethernet/chelsio/cxgb/subr.c:630 t1_link_start()
warn: was shift intended here '(mac->adapter->params.nports < 2)'
drivers/net/ethernet/chelsio/cxgb/subr.c
623 int t1_link_start(struct cphy *phy, struct cmac *mac, struct link_config *lc)
624 {
625 unsigned int fc = lc->requested_fc & (PAUSE_RX | PAUSE_TX);
626
627 if (lc->supported & SUPPORTED_Autoneg) {
628 lc->advertising &= ~(ADVERTISED_ASYM_PAUSE | ADVERTISED_PAUSE);
629 if (fc) {
630 if (fc == ((PAUSE_RX | PAUSE_TX) &
631 (mac->adapter->params.nports < 2)))
This condition is never weird. PAUSE_RX is 1. PAUSE_TX is 2.
The nports < 2 condition is either 0 or 1. We know fc is in 1-3 range.
We could re-write it as:
if (fc == 1 && mac->adapter->params.nports < 2)
The static checker is suggesting that we could do nports << 2 but then
the condition would never be true so that can't be right.
632 lc->advertising |= ADVERTISED_PAUSE;
633 else {
634 lc->advertising |= ADVERTISED_ASYM_PAUSE;
635 if (fc == PAUSE_RX)
636 lc->advertising |= ADVERTISED_PAUSE;
637 }
638 }
639 phy->ops->advertise(phy, lc->advertising);
regards,
dan carpenter
reply other threads:[~2015-12-14 19:58 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151214195842.GA20848@mwanda \
--to=dan.carpenter@oracle.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.