All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>
Cc: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
	Will Deacon <will.deacon@arm.com>,
	Andrew Pinski <andrew.pinski@caviumnetworks.com>,
	Davidlohr Bueso <dbueso@suse.de>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Commit 81a43adae3b9 (locking/mutex: Use acquire/release semantics) causing failures on arm64 (ThunderX)
Date: Mon, 14 Dec 2015 21:31:54 +0100	[thread overview]
Message-ID: <20151214203154.GY6357@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <20151214184931.7166827d@lxorguk.ukuu.org.uk>

On Mon, Dec 14, 2015 at 06:49:31PM +0000, One Thousand Gnomes wrote:
> 
> But seriously are there any cases we actually care about this for osq ?

So I think what PaulMck is worried about is that one would expect things
like:

	mutex_lock();
	MMIO(++var);
	mutex_unlock();

(the same example Linus gave but with a mutex instead of a spinlock) to
just work.

Now, I haven't checked the code, but I'm not sure we ever rely on osq to
provide the mutex ACQUIRE barrier, since we always need to acquire the
mutex variable itself after we've acquired the osq 'lock'.


  reply	other threads:[~2015-12-14 20:32 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-10 19:43 Commit 81a43adae3b9 (locking/mutex: Use acquire/release semantics) causing failures on arm64 (ThunderX) David Daney
2015-12-10 19:43 ` David Daney
     [not found] ` <SN1PR07MB21577C72379C8440A208D6BC9EEA0@SN1PR07MB2157.namprd07.prod.outlook.com>
2015-12-11  3:29   ` FW: " Andrew Pinski
2015-12-11  3:29     ` Andrew Pinski
2015-12-11  4:51     ` Andrew Pinski
2015-12-11  4:51       ` Andrew Pinski
2015-12-11  8:41       ` Peter Zijlstra
2015-12-11  8:41         ` Peter Zijlstra
2015-12-11 12:04         ` Will Deacon
2015-12-11 12:04           ` Will Deacon
2015-12-11 12:13           ` Peter Zijlstra
2015-12-11 12:13             ` Peter Zijlstra
2015-12-11 12:18             ` Will Deacon
2015-12-11 12:18               ` Will Deacon
2015-12-11 12:26               ` Peter Zijlstra
2015-12-11 12:26                 ` Peter Zijlstra
2015-12-11 13:33                 ` Will Deacon
2015-12-11 13:33                   ` Will Deacon
2015-12-11 13:48                   ` Peter Zijlstra
2015-12-11 13:48                     ` Peter Zijlstra
2015-12-11 14:06                     ` Will Deacon
2015-12-11 14:06                       ` Will Deacon
2015-12-11 17:11                       ` Peter Zijlstra
2015-12-11 17:11                         ` Peter Zijlstra
2015-12-11 17:24                         ` Will Deacon
2015-12-11 17:24                           ` Will Deacon
2015-12-11 22:35                     ` Paul E. McKenney
2015-12-11 22:35                       ` Paul E. McKenney
2015-12-14 18:49                       ` One Thousand Gnomes
2015-12-14 20:31                         ` Peter Zijlstra [this message]
2015-12-15  4:36                         ` Paul E. McKenney
2015-12-14 20:28                       ` FW: " Peter Zijlstra
2015-12-14 20:28                         ` Peter Zijlstra
2015-12-15  4:36                         ` Paul E. McKenney
2015-12-15  4:36                           ` Paul E. McKenney
2015-12-11 14:17           ` Davidlohr Bueso
2015-12-11 14:17             ` Davidlohr Bueso
2015-12-17 21:52           ` Jeremy Linton
2015-12-17 21:52             ` Jeremy Linton
2015-12-11  7:33     ` Peter Zijlstra
2015-12-11  7:33       ` Peter Zijlstra
2015-12-11  9:59 ` Will Deacon
2015-12-11  9:59   ` Will Deacon
  -- strict thread matches above, loose matches on Subject: below --
2015-12-11 17:43 Andrew Pinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151214203154.GY6357@twins.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=andrew.pinski@caviumnetworks.com \
    --cc=dbueso@suse.de \
    --cc=gnomes@lxorguk.ukuu.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=tglx@linutronix.de \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.