From mboxrd@z Thu Jan 1 00:00:00 1970 From: Borislav Petkov Subject: Re: [Patch V2 1/2] x86, mce: Basic support to add LMCE support to QEMU Date: Mon, 14 Dec 2015 23:37:16 +0100 Message-ID: <20151214223716.GK11630@pd.tnic> References: <1449776482-26070-1-git-send-email-ashok.raj@intel.com> <20151214162356.GA5314@thinpad.lan.raisama.net> <20151214163738.GJ11630@pd.tnic> <20151214191145.GB18012@otc-brkl-03.jf.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Cc: qemu-devel@nongnu.org, Tony Luck , Eduardo Habkost , kvm@vger.kernel.org, Gleb Natapov , linux-kernel@vger.kernel.org, Gong Chen , Andi Kleen , Paolo Bonzini To: "Raj, Ashok" Return-path: Content-Disposition: inline In-Reply-To: <20151214191145.GB18012@otc-brkl-03.jf.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org List-Id: kvm.vger.kernel.org On Mon, Dec 14, 2015 at 02:11:46PM -0500, Raj, Ashok wrote: > This is mostly harmless.. since the MCG_CAP space is shared and has no > conflict between vendors. Also just the CAP being set has no effect. Of course it does - we check SER_P in machine_check_poll() and when I emulate an AMD guest and inject errors into it, error handling is obviously wrong, see: https://lkml.kernel.org/r/20151123150355.GE5134@pd.tnic --=20 Regards/Gruss, Boris. SUSE Linux GmbH, GF: Felix Imend=C3=B6rffer, Jane Smithard, Graham Norton= , HRB 21284 (AG N=C3=BCrnberg) --=20 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933100AbbLNWha (ORCPT ); Mon, 14 Dec 2015 17:37:30 -0500 Received: from mx2.suse.de ([195.135.220.15]:44312 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932725AbbLNWhZ (ORCPT ); Mon, 14 Dec 2015 17:37:25 -0500 Date: Mon, 14 Dec 2015 23:37:16 +0100 From: Borislav Petkov To: "Raj, Ashok" Cc: Eduardo Habkost , kvm@vger.kernel.org, Tony Luck , Gong Chen , Gleb Natapov , linux-kernel@vger.kernel.org, qemu-devel@nongnu.org, Andi Kleen , Paolo Bonzini Subject: Re: [Qemu-devel] [Patch V2 1/2] x86, mce: Basic support to add LMCE support to QEMU Message-ID: <20151214223716.GK11630@pd.tnic> References: <1449776482-26070-1-git-send-email-ashok.raj@intel.com> <20151214162356.GA5314@thinpad.lan.raisama.net> <20151214163738.GJ11630@pd.tnic> <20151214191145.GB18012@otc-brkl-03.jf.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20151214191145.GB18012@otc-brkl-03.jf.intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 14, 2015 at 02:11:46PM -0500, Raj, Ashok wrote: > This is mostly harmless.. since the MCG_CAP space is shared and has no > conflict between vendors. Also just the CAP being set has no effect. Of course it does - we check SER_P in machine_check_poll() and when I emulate an AMD guest and inject errors into it, error handling is obviously wrong, see: https://lkml.kernel.org/r/20151123150355.GE5134@pd.tnic -- Regards/Gruss, Boris. SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg) -- From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54294) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a8bkG-0000GM-TB for qemu-devel@nongnu.org; Mon, 14 Dec 2015 17:37:29 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a8bkB-000625-U6 for qemu-devel@nongnu.org; Mon, 14 Dec 2015 17:37:28 -0500 Received: from mx2.suse.de ([195.135.220.15]:56778) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a8bkB-000621-Nl for qemu-devel@nongnu.org; Mon, 14 Dec 2015 17:37:23 -0500 Date: Mon, 14 Dec 2015 23:37:16 +0100 From: Borislav Petkov Message-ID: <20151214223716.GK11630@pd.tnic> References: <1449776482-26070-1-git-send-email-ashok.raj@intel.com> <20151214162356.GA5314@thinpad.lan.raisama.net> <20151214163738.GJ11630@pd.tnic> <20151214191145.GB18012@otc-brkl-03.jf.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20151214191145.GB18012@otc-brkl-03.jf.intel.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [Patch V2 1/2] x86, mce: Basic support to add LMCE support to QEMU List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Raj, Ashok" Cc: qemu-devel@nongnu.org, Tony Luck , Eduardo Habkost , kvm@vger.kernel.org, Gleb Natapov , linux-kernel@vger.kernel.org, Gong Chen , Andi Kleen , Paolo Bonzini On Mon, Dec 14, 2015 at 02:11:46PM -0500, Raj, Ashok wrote: > This is mostly harmless.. since the MCG_CAP space is shared and has no > conflict between vendors. Also just the CAP being set has no effect. Of course it does - we check SER_P in machine_check_poll() and when I emulate an AMD guest and inject errors into it, error handling is obviously wrong, see: https://lkml.kernel.org/r/20151123150355.GE5134@pd.tnic --=20 Regards/Gruss, Boris. SUSE Linux GmbH, GF: Felix Imend=C3=B6rffer, Jane Smithard, Graham Norton= , HRB 21284 (AG N=C3=BCrnberg) --=20