From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S964990AbbLOKhe (ORCPT <rfc822;w@1wt.eu>);
	Tue, 15 Dec 2015 05:37:34 -0500
Received: from vps0.lunn.ch ([178.209.37.122]:41624 "EHLO vps0.lunn.ch"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S964803AbbLOKhd (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 15 Dec 2015 05:37:33 -0500
Date: Tue, 15 Dec 2015 11:37:27 +0100
From: Andrew Lunn <andrew@lunn.ch>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: GregKH <greg@kroah.com>, maxime.ripard@free-electrons.com,
        wsa@the-dreams.de, broonie@kernel.org, vz@mleia.com, afd@ti.com,
        linux-kernel@vger.kernel.org, agust@denx.de
Subject: Re: [PATCH 6/6] eeprom: 93xx46: extend driver to plug into the NVMEM
 framework
Message-ID: <20151215103727.GD17792@lunn.ch>
References: <1449583511-22521-1-git-send-email-andrew@lunn.ch>
 <1449583511-22521-7-git-send-email-andrew@lunn.ch>
 <566FE5D4.1060601@linaro.org>
 <20151215101715.GC17792@lunn.ch>
 <566FEAE7.10109@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <566FEAE7.10109@linaro.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Dec 15, 2015 at 10:26:47AM +0000, Srinivas Kandagatla wrote:
> + adding Anatolij
> 
> On 15/12/15 10:17, Andrew Lunn wrote:
> >>Is there a reason for this driver to be using the old style?
> >>I can understand the issues with at24/at25 but does this driver also
> >>suffer from such issues?
> >
> >In order to keep backwards compatibility, we need the older file in
> >/sys. The only other option is to remove it and see if anybody
> >complains about us breaking the ABI.
> We should atleast attempt to pitch in this direction, and ask if
> somebody really cares if the location of the eeprom/nvmem file
> matters to them?

I expect it does matter.

This driver does not implement the in kernel API for accessing the
EEPROM. That means all users are in user space. And if this file
moves, it seems very likely these user space users break.

       Andrew