From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gustavo Padovan Subject: Re: [PATCH] android: fix warning when releasing active sync point Date: Tue, 15 Dec 2015 11:30:20 -0200 Message-ID: <20151215133020.GD883@joana> References: <20151215012955.GA28277@dtor-ws> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-qk0-f174.google.com (mail-qk0-f174.google.com [209.85.220.174]) by gabe.freedesktop.org (Postfix) with ESMTPS id 092DF6E259 for ; Tue, 15 Dec 2015 05:30:27 -0800 (PST) Received: by mail-qk0-f174.google.com with SMTP id b125so11971071qkf.2 for ; Tue, 15 Dec 2015 05:30:26 -0800 (PST) Content-Disposition: inline In-Reply-To: <20151215012955.GA28277@dtor-ws> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Dmitry Torokhov Cc: devel@driverdev.osuosl.org, Andrew Bresticker , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Arve =?iso-8859-1?B?SGr4bm5lduVn?= , Riley Andrews , linux-media@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org MjAxNS0xMi0xNCBEbWl0cnkgVG9yb2tob3YgPGR0b3JAY2hyb21pdW0ub3JnPjoKCj4gVXNlcnNw YWNlIGNhbiBjbG9zZSB0aGUgc3luYyBkZXZpY2Ugd2hpbGUgdGhlcmUgYXJlIHN0aWxsIGFjdGl2 ZSBmZW5jZQo+IHBvaW50cywgaW4gd2hpY2ggY2FzZSBrZXJuZWwgcHJvZHVjZXMgdGhlIGZvbGxv d2luZyB3YXJuaW5nOgo+IAo+IFsgICA0My44NTMxNzZdIC0tLS0tLS0tLS0tLVsgY3V0IGhlcmUg XS0tLS0tLS0tLS0tLQo+IFsgICA0My44NTc4MzRdIFdBUk5JTkc6IENQVTogMCBQSUQ6IDg5MiBh dCAvbW50L2hvc3Qvc291cmNlL3NyYy90aGlyZF9wYXJ0eS9rZXJuZWwvdjMuMTgvZHJpdmVycy9z dGFnaW5nL2FuZHJvaWQvc3luYy5jOjQzOSBhbmRyb2lkX2ZlbmNlX3JlbGVhc2UrMHg4OC8weDEw NCgpCj4gWyAgIDQzLjg3MTc0MV0gQ1BVOiAwIFBJRDogODkyIENvbW06IEJpbmRlcl81IFRhaW50 ZWQ6IEcgICAgIFUgMy4xOC4wLTA3NjYxLWcwNTUwY2U5ICMxCj4gWyAgIDQzLjg4MDE3Nl0gSGFy ZHdhcmUgbmFtZTogR29vZ2xlIFRlZ3JhMjEwIFNtYXVnIFJldiAxKyAoRFQpCj4gWyAgIDQzLjg4 NTgzNF0gQ2FsbCB0cmFjZToKPiBbICAgNDMuODg4Mjk0XSBbPGZmZmZmZmMwMDAyMDc0NjQ+XSBk dW1wX2JhY2t0cmFjZSsweDAvMHgxMGMKPiBbICAgNDMuODkzNjk3XSBbPGZmZmZmZmMwMDAyMDc1 ODA+XSBzaG93X3N0YWNrKzB4MTAvMHgxYwo+IFsgICA0My44OTg3NTZdIFs8ZmZmZmZmYzAwMGFi MTI1OD5dIGR1bXBfc3RhY2srMHg3NC8weGI4Cj4gWyAgIDQzLjkwMzgxNF0gWzxmZmZmZmZjMDAw MjFkNDE0Pl0gd2Fybl9zbG93cGF0aF9jb21tb24rMHg4NC8weGIwCj4gWyAgIDQzLjkwOTczNl0g WzxmZmZmZmZjMDAwMjFkNTMwPl0gd2Fybl9zbG93cGF0aF9udWxsKzB4MTQvMHgyMAo+IFsgICA0 My45MTU0ODJdIFs8ZmZmZmZmYzAwMDg4YWVmYz5dIGFuZHJvaWRfZmVuY2VfcmVsZWFzZSsweDg0 LzB4MTA0Cj4gWyAgIDQzLjkyMTU4Ml0gWzxmZmZmZmZjMDAwNjcxY2M0Pl0gZmVuY2VfcmVsZWFz ZSsweDEwNC8weDEzNAo+IFsgICA0My45MjcwNjZdIFs8ZmZmZmZmYzAwMDg4YjBjYz5dIHN5bmNf ZmVuY2VfZnJlZSsweDc0LzB4OWMKPiBbICAgNDMuOTMyNTUyXSBbPGZmZmZmZmMwMDA4OGIxMjg+ XSBzeW5jX2ZlbmNlX3JlbGVhc2UrMHgzNC8weDQ4Cj4gWyAgIDQzLjkzODMwNF0gWzxmZmZmZmZj MDAwMzE3YmJjPl0gX19mcHV0KzB4MTAwLzB4MWI4Cj4gWyAgIDQzLjk0MzE4NV0gWzxmZmZmZmZj MDAwMzE3Y2M4Pl0gX19fX2ZwdXQrMHg4LzB4MTQKPiBbICAgNDMuOTQ3OTgyXSBbPGZmZmZmZmMw MDAyMzdmMzg+XSB0YXNrX3dvcmtfcnVuKzB4YjAvMHhlNAo+IFsgICA0My45NTMyOTddIFs8ZmZm ZmZmYzAwMDIwNzA3ND5dIGRvX25vdGlmeV9yZXN1bWUrMHg0NC8weDVjCj4gWyAgIDQzLjk1ODg2 N10gLS0tWyBlbmQgdHJhY2UgNWEyYWE0MDI3Y2M1ZDE3MSBdLS0tCgpUaGlzIGNyYXNoIHJlcG9y dCBzZWVtcyB0byBiZSBmb3IgYSAzLjE4IGtlcm5lbC4gQ2FuIHlvdSByZXByb2R1Y2UgaXQKb24g dXBzdHJlYW0ga2VybmVsIGFzIHdlbGw/CgoJR3VzdGF2bwpfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZl bEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWls bWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-qk0-f182.google.com ([209.85.220.182]:35101 "EHLO mail-qk0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933190AbbLONa1 (ORCPT ); Tue, 15 Dec 2015 08:30:27 -0500 Date: Tue, 15 Dec 2015 11:30:20 -0200 From: Gustavo Padovan To: Dmitry Torokhov Cc: Greg Kroah-Hartman , devel@driverdev.osuosl.org, Andrew Bresticker , Arve =?iso-8859-1?B?SGr4bm5lduVn?= , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Riley Andrews , linux-media@vger.kernel.org Subject: Re: [PATCH] android: fix warning when releasing active sync point Message-ID: <20151215133020.GD883@joana> References: <20151215012955.GA28277@dtor-ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151215012955.GA28277@dtor-ws> Sender: linux-media-owner@vger.kernel.org List-ID: 2015-12-14 Dmitry Torokhov : > Userspace can close the sync device while there are still active fence > points, in which case kernel produces the following warning: > > [ 43.853176] ------------[ cut here ]------------ > [ 43.857834] WARNING: CPU: 0 PID: 892 at /mnt/host/source/src/third_party/kernel/v3.18/drivers/staging/android/sync.c:439 android_fence_release+0x88/0x104() > [ 43.871741] CPU: 0 PID: 892 Comm: Binder_5 Tainted: G U 3.18.0-07661-g0550ce9 #1 > [ 43.880176] Hardware name: Google Tegra210 Smaug Rev 1+ (DT) > [ 43.885834] Call trace: > [ 43.888294] [] dump_backtrace+0x0/0x10c > [ 43.893697] [] show_stack+0x10/0x1c > [ 43.898756] [] dump_stack+0x74/0xb8 > [ 43.903814] [] warn_slowpath_common+0x84/0xb0 > [ 43.909736] [] warn_slowpath_null+0x14/0x20 > [ 43.915482] [] android_fence_release+0x84/0x104 > [ 43.921582] [] fence_release+0x104/0x134 > [ 43.927066] [] sync_fence_free+0x74/0x9c > [ 43.932552] [] sync_fence_release+0x34/0x48 > [ 43.938304] [] __fput+0x100/0x1b8 > [ 43.943185] [] ____fput+0x8/0x14 > [ 43.947982] [] task_work_run+0xb0/0xe4 > [ 43.953297] [] do_notify_resume+0x44/0x5c > [ 43.958867] ---[ end trace 5a2aa4027cc5d171 ]--- This crash report seems to be for a 3.18 kernel. Can you reproduce it on upstream kernel as well? Gustavo