Re: problem vhost-user sockets

[Yuanhan Liu <yuanhan.liu@linux.intel.com>]

On Tue, Dec 15, 2015 at 03:41:23PM +0300, Pavel Fedin wrote:
>  Hello!
> 
>  I have a question regarding vhostuser. If we cannot bind to a socket, why do we simply fail with error instead of just unlink()ing
> the path before binding?

I'm thinking you can't simply unlink a file given by a user inside
a libraray unconditionaly. Say, what if a user gives a wrong socket
path?

> 
>  This causes a very annoying problem with ovs. After ovs is stopped (i use supplied system integration), these sockets are not
> removed. Looks like ovs just exits without correct cleanup. This effectively causes my vhostuser interfaces to go down until i clean
> them up manually. And i have to do it after every ovs restart, every system reboot, etc. It is very annoying.
>  I understand that the app should really do correct cleanup upon exit. But what if it abnormally crashes because of some reason
> (bug, attack, etc)? Shouldn't it be able to automatically recover?

I normally write a short script to handle it automatically.

	--yliu