All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v2 1/2] preadv/preadv01.c: add new testcase
Date: Tue, 15 Dec 2015 15:40:44 +0100	[thread overview]
Message-ID: <20151215144044.GD26217@rei.lan> (raw)
In-Reply-To: <1449142273-10679-1-git-send-email-yangx.jy@cn.fujitsu.com>

Hi!
> +	if (i < tc->size) {
> +		tst_resm(TFAIL, "Buffer wrong at %i have %c expected a",
> +			 i, vec[i]);

I've changed the %c to %x since more than half of the char values are
non-printable ones and will probably mess up terminal.

> +	ret = tst_fill_file("file", 0x61, CHUNK, 2);
> +	if (ret)
> +		tst_brkm(TBROK | TERRNO, cleanup, "Failed to fill test file");

Change to single tst_fill_file() is not a good one. Since that way we
cannot say that the offset parameter for the syscall is working as
expected. So I changed this part to go with memset() and SAFE_WRITE()
and pushed, thanks.

-- 
Cyril Hrubis
chrubis@suse.cz

      parent reply	other threads:[~2015-12-15 14:40 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-03 22:57 [LTP] [PATCH 1/2] preadv/preadv01.c: add new testcase Xiao Yang
2015-11-03 14:30 ` Cyril Hrubis
2015-11-04  6:33   ` yangx.jy
2015-11-04 11:51     ` Cyril Hrubis
2015-11-03 22:57 ` [LTP] [PATCH 2/2] pwritev/pwritev01.c: " Xiao Yang
2015-11-03 14:46   ` Cyril Hrubis
2015-12-03 11:31     ` [LTP] [PATCH v2 1/2] preadv/preadv01.c: " Xiao Yang
2015-12-03 11:31       ` [LTP] [PATCH v2 2/2] pwritev/pwritev01.c: " Xiao Yang
2015-12-15 16:36         ` Cyril Hrubis
2015-12-15 14:40       ` Cyril Hrubis [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151215144044.GD26217@rei.lan \
    --to=chrubis@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.