From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:51665 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932202AbbLORCX (ORCPT ); Tue, 15 Dec 2015 12:02:23 -0500 Date: Tue, 15 Dec 2015 09:02:22 -0800 From: Greg KH To: Sudeep Biswas Cc: DCG_UPD_stlinux_kernel@list.st.com, Will Deacon , stable@vger.kernel.org, Russell King Subject: Re: [PATCH v1.0(linux-sti-3.10) SDK2.15_x 3/4] ARM: 8191/1: decompressor: ensure I-side picks up relocated code Message-ID: <20151215170222.GC18302@kroah.com> References: <1450191476-14078-1-git-send-email-sudeep.biswas@st.com> <1450191476-14078-4-git-send-email-sudeep.biswas@st.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1450191476-14078-4-git-send-email-sudeep.biswas@st.com> Sender: stable-owner@vger.kernel.org List-ID: On Tue, Dec 15, 2015 at 08:27:55PM +0530, Sudeep Biswas wrote: > From: Will Deacon > > To speed up decompression, the decompressor sets up a flat, cacheable > mapping of memory. However, when there is insufficient space to hold > the page tables for this mapping, we don't bother to enable the caches > and subsequently skip all the cache maintenance hooks. > > Skipping the cache maintenance before jumping to the relocated code > allows the processor to predict the branch and populate the I-cache > with stale data before the relocation loop has completed (since a > bootloader may have SCTLR.I set, which permits normal, cacheable > instruction fetches regardless of SCTLR.M). > > This patch moves the cache maintenance check into the maintenance > routines themselves, allowing the v6/v7 versions to invalidate the > I-cache regardless of the MMU state. > > Cc: > Reported-by: Marc Carino > Tested-by: Julien Grall > Signed-off-by: Will Deacon > Signed-off-by: Russell King > (cherry picked from commit 238962ac71910d6c20162ea5230685fead1836a4) > > Buglink: https://stintbugzilla.st.com/show_bug.cgi?id=89771 > > Signed-off-by: Sudeep Biswas > --- > arch/arm/boot/compressed/head.S | 20 ++++++++++++++++---- > 1 files changed, 16 insertions(+), 4 deletions(-) I don't understand, this is a very old patch, why are you sending it out again, and what stable tree do you want it applied to that it is not already in? confused, greg k-h