diff for duplicates of <20151215190304.GA3724@mrl.redhat.com> diff --git a/a/1.txt b/N1/1.txt index 22e9c09..37364d4 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -179,7 +179,7 @@ and there is code that relies on this direct mapping, like in: nf_nat_l4proto_in_range(): __be16 port; - if (maniptype = NF_NAT_MANIP_SRC) + if (maniptype == NF_NAT_MANIP_SRC) port = tuple->src.u.all; else port = tuple->dst.u.all; @@ -187,11 +187,11 @@ nf_nat_l4proto_in_range(): nf_nat_ipv6_decode_session(): if (ct->status & statusbit) { fl6->daddr = t->dst.u3.in6; - if (t->dst.protonum = IPPROTO_TCP || - t->dst.protonum = IPPROTO_UDP || - t->dst.protonum = IPPROTO_UDPLITE || - t->dst.protonum = IPPROTO_DCCP || - t->dst.protonum = IPPROTO_SCTP) + if (t->dst.protonum == IPPROTO_TCP || + t->dst.protonum == IPPROTO_UDP || + t->dst.protonum == IPPROTO_UDPLITE || + t->dst.protonum == IPPROTO_DCCP || + t->dst.protonum == IPPROTO_SCTP) fl6->fl6_dport = t->dst.u.all; } @@ -216,7 +216,7 @@ and: ct_proto_port_check(): /* Shortcut to match all recognized protocols by using ->src.all. */ if ((info->match_flags & XT_CONNTRACK_ORIGSRC_PORT) && - (tuple->src.u.all = info->origsrc_port) ^ + (tuple->src.u.all == info->origsrc_port) ^ !(info->invert_flags & XT_CONNTRACK_ORIGSRC_PORT)) return false; diff --git a/a/content_digest b/N1/content_digest index c0431b1..a6a95d8 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -6,7 +6,7 @@ "ref\020151210170647.GA1547@salvia\0" "From\0Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>\0" "Subject\0Re: [PATCH] netfilter: nf_ct_sctp: validate vtag for new conntrack entries\0" - "Date\0Tue, 15 Dec 2015 19:03:04 +0000\0" + "Date\0Tue, 15 Dec 2015 17:03:04 -0200\0" "To\0Pablo Neira Ayuso <pablo@netfilter.org>\0" "Cc\0netfilter-devel@vger.kernel.org" linux-sctp@vger.kernel.org @@ -196,7 +196,7 @@ "nf_nat_l4proto_in_range():\n" " __be16 port;\n" "\n" - " if (maniptype = NF_NAT_MANIP_SRC)\n" + " if (maniptype == NF_NAT_MANIP_SRC)\n" " port = tuple->src.u.all;\n" " else\n" " port = tuple->dst.u.all;\n" @@ -204,11 +204,11 @@ "nf_nat_ipv6_decode_session():\n" " if (ct->status & statusbit) {\n" " fl6->daddr = t->dst.u3.in6;\n" - " if (t->dst.protonum = IPPROTO_TCP ||\n" - " t->dst.protonum = IPPROTO_UDP ||\n" - " t->dst.protonum = IPPROTO_UDPLITE ||\n" - " t->dst.protonum = IPPROTO_DCCP ||\n" - " t->dst.protonum = IPPROTO_SCTP)\n" + " if (t->dst.protonum == IPPROTO_TCP ||\n" + " t->dst.protonum == IPPROTO_UDP ||\n" + " t->dst.protonum == IPPROTO_UDPLITE ||\n" + " t->dst.protonum == IPPROTO_DCCP ||\n" + " t->dst.protonum == IPPROTO_SCTP)\n" " fl6->fl6_dport = t->dst.u.all;\n" " }\n" "\n" @@ -233,7 +233,7 @@ "ct_proto_port_check():\n" " /* Shortcut to match all recognized protocols by using ->src.all. */\n" " if ((info->match_flags & XT_CONNTRACK_ORIGSRC_PORT) &&\n" - " (tuple->src.u.all = info->origsrc_port) ^\n" + " (tuple->src.u.all == info->origsrc_port) ^\n" " !(info->invert_flags & XT_CONNTRACK_ORIGSRC_PORT))\n" " return false;\n" "\n" @@ -242,4 +242,4 @@ "Thanks,\n" Marcelo -e312f0a00bea575b661bad4b4be8644a9f7c9f252efbacfcbfdc51d1ab7113cb +bc7eb0d5300ba2b63bc2b14671e0e65a590cd85c654b5cb104b416329b005da5
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.