From: Dan Carpenter <dan.carpenter@oracle.com>
To: Tadeusz Struk <tadeusz.struk@intel.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
Bruce Allan <bruce.w.allan@intel.com>,
Pingchao Yang <pingchao.yang@intel.com>,
qat-linux@intel.com, linux-crypto@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] crypto: qat - fix some timeout tests
Date: Tue, 15 Dec 2015 23:50:31 +0000 [thread overview]
Message-ID: <20151215235031.GK5177@mwanda> (raw)
In-Reply-To: <567077AB.8040602@intel.com>
On Tue, Dec 15, 2015 at 12:27:23PM -0800, Tadeusz Struk wrote:
> Since the times var is an signed int I think we should rather change the condition:
I don't see what signed int has to do with anything.
>
> diff --git a/drivers/crypto/qat/qat_common/qat_hal.c b/drivers/crypto/qat/qat_common/qat_hal.c
> index 45c1739..864a5ea 100644
> --- a/drivers/crypto/qat/qat_common/qat_hal.c
> +++ b/drivers/crypto/qat/qat_common/qat_hal.c
> @@ -186,7 +186,7 @@ static int qat_hal_wait_cycles(struct icp_qat_fw_loader_handle *handle,
> if (elapsed_cycles >= 8 && !(csr & (1 << ACS_ABO_BITPOS)))
> return 0;
> }
> - if (!times) {
> + if (!(0 < times)) {
Oh, wow that's nasty! Why would you write it in such an obfuscated way?
Plus it's buggy and wrong... What on earth.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Tadeusz Struk <tadeusz.struk@intel.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
Bruce Allan <bruce.w.allan@intel.com>,
Pingchao Yang <pingchao.yang@intel.com>,
qat-linux@intel.com, linux-crypto@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] crypto: qat - fix some timeout tests
Date: Wed, 16 Dec 2015 02:50:31 +0300 [thread overview]
Message-ID: <20151215235031.GK5177@mwanda> (raw)
In-Reply-To: <567077AB.8040602@intel.com>
On Tue, Dec 15, 2015 at 12:27:23PM -0800, Tadeusz Struk wrote:
> Since the times var is an signed int I think we should rather change the condition:
I don't see what signed int has to do with anything.
>
> diff --git a/drivers/crypto/qat/qat_common/qat_hal.c b/drivers/crypto/qat/qat_common/qat_hal.c
> index 45c1739..864a5ea 100644
> --- a/drivers/crypto/qat/qat_common/qat_hal.c
> +++ b/drivers/crypto/qat/qat_common/qat_hal.c
> @@ -186,7 +186,7 @@ static int qat_hal_wait_cycles(struct icp_qat_fw_loader_handle *handle,
> if (elapsed_cycles >= 8 && !(csr & (1 << ACS_ABO_BITPOS)))
> return 0;
> }
> - if (!times) {
> + if (!(0 < times)) {
Oh, wow that's nasty! Why would you write it in such an obfuscated way?
Plus it's buggy and wrong... What on earth.
regards,
dan carpenter
next prev parent reply other threads:[~2015-12-15 23:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-15 10:05 [patch] crypto: qat - fix some timeout tests Dan Carpenter
2015-12-15 10:05 ` Dan Carpenter
2015-12-15 20:27 ` Tadeusz Struk
2015-12-15 20:27 ` Tadeusz Struk
2015-12-15 23:50 ` Dan Carpenter [this message]
2015-12-15 23:50 ` Dan Carpenter
-- strict thread matches above, loose matches on Subject: below --
2015-12-16 6:09 [PATCH] " Yang Pingchao
2015-12-16 6:09 ` Yang Pingchao
2015-12-22 13:23 ` Herbert Xu
2015-12-22 13:23 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151215235031.GK5177@mwanda \
--to=dan.carpenter@oracle.com \
--cc=bruce.w.allan@intel.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=pingchao.yang@intel.com \
--cc=qat-linux@intel.com \
--cc=tadeusz.struk@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.