All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Trimarchi <michael@amarulasolutions.com>
To: Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
	linux-gpio@vger.kernel.org, michael@amarulasolutions.com
Subject: BGPIOF_READ_OUTPUT_REG_SET problem
Date: Wed, 16 Dec 2015 15:05:02 +0100	[thread overview]
Message-ID: <20151216140456.GA20121@panicking> (raw)

Hi

I have get a problem using gpio and imx6q freescale architecture. I don't
really understand how should work your change and I have done a quick
fix for me. Can you explain what was the idea?

Michael

diff --git a/drivers/gpio/gpio-generic.c b/drivers/gpio/gpio-generic.c
index a3f0753..f9c6ff7 100644
--- a/drivers/gpio/gpio-generic.c
+++ b/drivers/gpio/gpio-generic.c
@@ -139,11 +139,14 @@ static int bgpio_get_set(struct gpio_chip *gc, unsigned int gpio)
 {
 	struct bgpio_chip *bgc = to_bgpio_chip(gc);
 	unsigned long pinmask = bgc->pin2mask(bgc, gpio);
+	unsigned long reg;
 
 	if (bgc->dir & pinmask)
-		return bgc->read_reg(bgc->reg_set) & pinmask;
+		reg = bgc->read_reg(bgc->reg_set) & pinmask;
 	else
-		return bgc->read_reg(bgc->reg_dat) & pinmask;
+		reg = bgc->read_reg(bgc->reg_dat) & pinmask;
+
+	return !!(reg &  bgc->pin2mask(bgc, gpio));
 }
 
 static int bgpio_get(struct gpio_chip *gc, unsigned int gpio)
-- 
| Michael Nazzareno Trimarchi                     Amarula Solutions BV |
| COO  -  Founder                                      Cruquiuskade 47 |
| +31(0)851119172                                 Amsterdam 1018 AM NL |
|                  [`as] http://www.amarulasolutions.com               |

             reply	other threads:[~2015-12-16 14:05 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-16 14:05 Michael Trimarchi [this message]
2015-12-16 14:50 ` BGPIOF_READ_OUTPUT_REG_SET problem Vladimir Zapolskiy
2015-12-16 15:25   ` Michael Trimarchi
2015-12-16 18:17     ` Michael Trimarchi
2015-12-16 19:18       ` Vladimir Zapolskiy
     [not found]         ` <CAOf5uwmM2T6VVVfBLUED5=a4ZMpY10oJg_r3FCzAW+XkRLxbww@mail.gmail.com>
2015-12-16 20:01           ` Vladimir Zapolskiy
2015-12-17  7:31             ` Michael Trimarchi
2015-12-16 18:58     ` Vladimir Zapolskiy
2015-12-17  9:09       ` Linus Walleij
2015-12-17  9:00 ` Linus Walleij
2015-12-17  9:04   ` Michael Trimarchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151216140456.GA20121@panicking \
    --to=michael@amarulasolutions.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=vladimir_zapolskiy@mentor.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.