From: Thierry Reding <thierry.reding@gmail.com>
To: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: Qipeng Zha <qipeng.zha@intel.com>, linux-pwm@vger.kernel.org
Subject: Re: [PATCH] pwm: lpss: Remove ->free() callback
Date: Wed, 16 Dec 2015 16:40:44 +0100 [thread overview]
Message-ID: <20151216154044.GD28947@ulmo> (raw)
In-Reply-To: <1449669959-55013-1-git-send-email-mika.westerberg@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 812 bytes --]
On Wed, Dec 09, 2015 at 04:05:59PM +0200, Mika Westerberg wrote:
> The LPSS PWM driver calls pwm_lpss_disable() when the PWM device is
> released (for example unexported from sysfs). This in turn calls
> pm_runtime_put() which makes runtime PM count to be unbalanced if the
> device has not been enabled at this point.
>
> This is easy to reproduce:
>
> # cd /sys/class/pwm/pwmchip0
> # echo 0 > export
> # echo 0 > unexport
>
> The count is unbalanced and prevents the PWM device from being powered on
> next time.
>
> Fix this by removing ->free() callback. There are no resources to be
> released anyway.
>
> Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> ---
> drivers/pwm/pwm-lpss.c | 1 -
> 1 file changed, 1 deletion(-)
Applied, thanks.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2015-12-16 15:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-09 14:05 [PATCH] pwm: lpss: Remove ->free() callback Mika Westerberg
2015-12-16 15:40 ` Thierry Reding [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151216154044.GD28947@ulmo \
--to=thierry.reding@gmail.com \
--cc=linux-pwm@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=qipeng.zha@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.