Re: [PATCH 2/2] pwm: lpss: Rework the sequence of programming PWM_SW_UPDATE

[Thierry Reding <thierry.reding@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1196 bytes --]

On Wed, Nov 18, 2015 at 01:25:18PM +0200, Mika Westerberg wrote:
> Setting of PWM_SW_UPDATE is bit different in Intel Broxton compared to the
> previous generation SoCs. Previously it was OK to set the bit many times
> (from userspace via sysfs for example) before the PWM is actually enabled.
> 
> Starting from Intel Broxton it seems that we must set PWM_SW_UPDATE only
> once before the PWM is enabled. Otherwise it is possible that the PWM does
> not start properly.
> 
> Change the sequence of how PWM_SW_UPDATE is programmed so that we only set
> it in pwm_lpss_config() when the PWM is already enabled. The initial
> setting of PWM_SW_UPDATE will be done when PWM gets enabled. This should
> make the driver work with the previous generation Intel SoCs and Broxton.
> 
> Add also small delay after the bit is set to let the hardware propagate it
> properly.
> 
> Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> ---
> Applies on top of Qipeng's patch here:
> 
> https://patchwork.ozlabs.org/patch/545313/
> 
>  drivers/pwm/pwm-lpss.c | 23 +++++++++++++++++++++--
>  1 file changed, 21 insertions(+), 2 deletions(-)

Applied, thanks.

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]