From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
Sasha Levin <sasha.levin@oracle.com>
Subject: Re: linux-next: build failure after merge of the rtc tree
Date: Thu, 17 Dec 2015 12:21:54 +0100 [thread overview]
Message-ID: <20151217112154.GE13078@piout.net> (raw)
In-Reply-To: <20151217160344.096b4a9e@canb.auug.org.au>
On 17/12/2015 at 16:03:44 +1100, Stephen Rothwell wrote :
> Hi Alexandre,
>
> After merging the rtc tree, today's linux-next build (arm
> multi_v7_defconfig) failed like this:
>
> drivers/built-in.o: In function `rtc_time64_to_tm':
> sunxi_sid.c:(.text+0x366e54): undefined reference to `__aeabi_ldivmod'
> sunxi_sid.c:(.text+0x366e6c): undefined reference to `__aeabi_ldivmod'
>
> Caused by commit
>
> bfad4c280be0 ("rtc: fix overflow and incorrect calculation in rtc_time64_to_tm")
>
> I have used the rtc tree from next-20151216 for today.
>
Well, the kbuild test robot didn't complain at the time so I assumed
that it was ok to take the patch but indeed, there are more division
further in the function.
Sasha, I think I prefer having 32 bit platforms fail on the 21st of
January 11761191 rather than adding more uses of do_div in the function.
I'll have a look at the performance impact on 32 bit platforms.
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Sasha Levin <sasha.levin@oracle.com>,
Stephen Rothwell <sfr@canb.auug.org.au>
Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
Sasha Levin <sasha.levin@oracle.com>
Subject: Re: linux-next: build failure after merge of the rtc tree
Date: Thu, 17 Dec 2015 12:21:54 +0100 [thread overview]
Message-ID: <20151217112154.GE13078@piout.net> (raw)
In-Reply-To: <20151217160344.096b4a9e@canb.auug.org.au>
On 17/12/2015 at 16:03:44 +1100, Stephen Rothwell wrote :
> Hi Alexandre,
>
> After merging the rtc tree, today's linux-next build (arm
> multi_v7_defconfig) failed like this:
>
> drivers/built-in.o: In function `rtc_time64_to_tm':
> sunxi_sid.c:(.text+0x366e54): undefined reference to `__aeabi_ldivmod'
> sunxi_sid.c:(.text+0x366e6c): undefined reference to `__aeabi_ldivmod'
>
> Caused by commit
>
> bfad4c280be0 ("rtc: fix overflow and incorrect calculation in rtc_time64_to_tm")
>
> I have used the rtc tree from next-20151216 for today.
>
Well, the kbuild test robot didn't complain at the time so I assumed
that it was ok to take the patch but indeed, there are more division
further in the function.
Sasha, I think I prefer having 32 bit platforms fail on the 21st of
January 11761191 rather than adding more uses of do_div in the function.
I'll have a look at the performance impact on 32 bit platforms.
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-12-17 11:21 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-17 5:03 linux-next: build failure after merge of the rtc tree Stephen Rothwell
2015-12-17 11:21 ` Alexandre Belloni [this message]
2015-12-17 11:21 ` Alexandre Belloni
2015-12-18 15:30 ` Sasha Levin
2015-12-18 16:43 ` Alexandre Belloni
2015-12-22 19:27 ` Alexandre Belloni
-- strict thread matches above, loose matches on Subject: below --
2016-11-08 6:41 Stephen Rothwell
2016-11-08 22:21 ` Alexandre Belloni
2017-04-10 6:04 Stephen Rothwell
2017-04-10 7:45 ` Hans de Goede
2017-04-11 0:22 ` Stephen Rothwell
2017-04-11 5:55 ` Alexandre Belloni
2017-04-11 7:52 ` Stephen Rothwell
2017-04-14 10:09 ` Alexandre Belloni
2017-04-14 16:33 ` Stephen Rothwell
2017-05-31 4:33 Stephen Rothwell
2017-05-31 5:45 ` Heiner Kallweit
2017-05-31 7:19 ` Alexandre Belloni
2019-02-08 5:55 Stephen Rothwell
2019-02-11 5:24 Stephen Rothwell
2019-10-04 4:37 Stephen Rothwell
2020-03-16 5:15 Stephen Rothwell
2020-03-16 6:58 ` Ran Bi
2020-03-16 10:31 ` Alexandre Belloni
2021-08-10 5:54 Stephen Rothwell
2021-09-27 3:10 Stephen Rothwell
2021-09-27 7:16 ` Romain Perier
2023-10-16 4:15 Stephen Rothwell
2023-10-16 4:34 ` Alexandre Belloni
2023-10-16 7:11 ` Uwe Kleine-König
2024-11-13 5:23 Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151217112154.GE13078@piout.net \
--to=alexandre.belloni@free-electrons.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sasha.levin@oracle.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.