From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Date: Thu, 17 Dec 2015 12:40:20 +0000 Subject: [patch 3/3 -next] drm/vc4: fix an error code Message-Id: <20151217124020.GC27382@mwanda> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: David Airlie , Eric Anholt Cc: kernel-janitors@vger.kernel.org, dri-devel@lists.freedesktop.org "exec->exec_bo" is NULL at this point so this code returns success. We want to return -ENOMEM. Fixes: d5b1a78a772f ('drm/vc4: Add support for drawing 3D frames.') Signed-off-by: Dan Carpenter diff --git a/drivers/gpu/drm/vc4/vc4_gem.c b/drivers/gpu/drm/vc4/vc4_gem.c index 2a680d9..98a25b8 100644 --- a/drivers/gpu/drm/vc4/vc4_gem.c +++ b/drivers/gpu/drm/vc4/vc4_gem.c @@ -580,7 +580,7 @@ vc4_get_bcl(struct drm_device *dev, struct vc4_exec_info *exec) bo = vc4_bo_create(dev, exec_size, true); if (!bo) { DRM_ERROR("Couldn't allocate BO for binning\n"); - ret = PTR_ERR(exec->exec_bo); + ret = -ENOMEM; goto fail; } exec->exec_bo = &bo->base; From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Subject: [patch 3/3 -next] drm/vc4: fix an error code Date: Thu, 17 Dec 2015 15:40:20 +0300 Message-ID: <20151217124020.GC27382@mwanda> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from userp1040.oracle.com (userp1040.oracle.com [156.151.31.81]) by gabe.freedesktop.org (Postfix) with ESMTPS id 84E4D6E1D3 for ; Thu, 17 Dec 2015 04:40:30 -0800 (PST) Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: David Airlie , Eric Anholt Cc: kernel-janitors@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org ImV4ZWMtPmV4ZWNfYm8iIGlzIE5VTEwgYXQgdGhpcyBwb2ludCBzbyB0aGlzIGNvZGUgcmV0dXJu cyBzdWNjZXNzLiAgV2UKd2FudCB0byByZXR1cm4gLUVOT01FTS4KCkZpeGVzOiBkNWIxYTc4YTc3 MmYgKCdkcm0vdmM0OiBBZGQgc3VwcG9ydCBmb3IgZHJhd2luZyAzRCBmcmFtZXMuJykKU2lnbmVk LW9mZi1ieTogRGFuIENhcnBlbnRlciA8ZGFuLmNhcnBlbnRlckBvcmFjbGUuY29tPgoKZGlmZiAt LWdpdCBhL2RyaXZlcnMvZ3B1L2RybS92YzQvdmM0X2dlbS5jIGIvZHJpdmVycy9ncHUvZHJtL3Zj NC92YzRfZ2VtLmMKaW5kZXggMmE2ODBkOS4uOThhMjViOCAxMDA2NDQKLS0tIGEvZHJpdmVycy9n cHUvZHJtL3ZjNC92YzRfZ2VtLmMKKysrIGIvZHJpdmVycy9ncHUvZHJtL3ZjNC92YzRfZ2VtLmMK QEAgLTU4MCw3ICs1ODAsNyBAQCB2YzRfZ2V0X2JjbChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LCBz dHJ1Y3QgdmM0X2V4ZWNfaW5mbyAqZXhlYykKIAlibyA9IHZjNF9ib19jcmVhdGUoZGV2LCBleGVj X3NpemUsIHRydWUpOwogCWlmICghYm8pIHsKIAkJRFJNX0VSUk9SKCJDb3VsZG4ndCBhbGxvY2F0 ZSBCTyBmb3IgYmlubmluZ1xuIik7Ci0JCXJldCA9IFBUUl9FUlIoZXhlYy0+ZXhlY19ibyk7CisJ CXJldCA9IC1FTk9NRU07CiAJCWdvdG8gZmFpbDsKIAl9CiAJZXhlYy0+ZXhlY19ibyA9ICZiby0+ YmFzZTsKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJp LWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6 Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK