Re: Automatic device driver back-porting with media_build

[Mauro Carvalho Chehab <mchehab@osg.samsung.com>]

Em Thu, 17 Dec 2015 15:30:43 +0100
Mason <slash.tmp@free.fr> escreveu:

> On 17/12/2015 15:08, Mauro Carvalho Chehab wrote:
> 
> > Then I guess you're not using vanilla 3.4 Kernel, but some heavily
> > modified version. You're on your own here.
> 
> #ifdef NEED_KVFREE
> #include <linux/mm.h>
> static inline void kvfree(const void *addr)
> {
> 	if (is_vmalloc_addr(addr))
> 		vfree(addr);
> 	else
> 		kfree(addr);
> }
> #endif
> 
> /tmp/sandbox/media_build/v4l/compat.h: In function 'kvfree':
> /tmp/sandbox/media_build/v4l/compat.h:1631:3: error: implicit declaration of function 'vfree' [-Werror=implicit-function-declaration]
>    vfree(addr);
>    ^
> 
> vfree is declared in linux/vmalloc.h
> 
> The fix is trivial:
> 
> diff --git a/v4l/compat.h b/v4l/compat.h
> index c225c07d6caa..7f3f1d5f9d11 100644
> --- a/v4l/compat.h
> +++ b/v4l/compat.h
> @@ -1625,6 +1625,7 @@ static inline void eth_zero_addr(u8 *addr)
>  
>  #ifdef NEED_KVFREE
>  #include <linux/mm.h>
> +#include <linux/vmalloc.h>
>  static inline void kvfree(const void *addr)
>  {
>         if (is_vmalloc_addr(addr))
> 
> 

Well, it doesn't hurt to add it to the media_build tree, since
vmalloc.h exists at least since 2.6.11.

Added upstream.

Did the driver compile fine?

Regards,
Mauro