From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Gortmaker Subject: Re: [PATCH v2] soc: mediatek: SCPSYS: use module_platform_driver Date: Thu, 17 Dec 2015 10:16:17 -0500 Message-ID: <20151217151617.GY2772@windriver.com> References: <1450263656-12513-1-git-send-email-s.hauer@pengutronix.de> <1562792.sV6cmsyeOM@wuerfel> <56715136.3060908@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+glpam-linux-mediatek=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Daniel Kurtz Cc: Arnd Bergmann , Sascha Hauer , Dawei Chien =?utf-8?B?KOmMouWkp+ihmyk=?= , linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Sasha Hauer , Matthias Brugger , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" List-Id: linux-mediatek@lists.infradead.org [Re: [PATCH v2] soc: mediatek: SCPSYS: use module_platform_driver] On 17/12/2015 (Thu 10:52) Daniel Kurtz wrote: [...] > > Also, since scpsys' Kconfig is "bool" not "tristate" it isn't a real > module so I think we should use: > builtin_platform_driver not module_platform_driver > > CC'ing Paul Gortmaker who seems to be on a mass > builtin_platform_driver conversion at the moment, see: > https://lkml.org/lkml/2015/12/9/952 > Good guess. In my giant queue I have that change. I just haven't got around to the requisite triple check and multi arch rebuild tests and put out a series for soc yet. Here is the short list for soc: drivers-soc-make-mediatek-mtk-scpsys.c-explicitly-no.patch drivers-soc-make-qcom-spm.c-explicitly-non-modular.patch drivers-soc-make-samsung-exynos-srom.c.c-explicitly-.patch drivers-soc-make-sunxi_sram.c-explicitly-non-modular.patch drivers-soc-tegra-make-fuse-tegra.c-explicitly-non-m.patch ...and here is the patch you predicted. If someone wants to fold the change into their work then great; I'll be happy to drop mine and be with one less patch to herd along. Paul. -- From eb32cc2c1db8192c08dd64af69cb172b3be4c98b Mon Sep 17 00:00:00 2001 From: Paul Gortmaker Date: Fri, 4 Sep 2015 19:33:54 -0400 Subject: [PATCH] drivers/soc: make mediatek/mtk-scpsys.c explicitly non-modular The Kconfig currently controlling compilation of this code is: drivers/soc/mediatek/Kconfig:config MTK_SCPSYS drivers/soc/mediatek/Kconfig: bool "MediaTek SCPSYS Support" ...meaning that it currently is not being built as a module by anyone. Lets remove the couple traces of modularity so that when reading the driver there is no doubt it is builtin-only. Since module_platform_driver() uses the same init level priority as builtin_platform_driver() the init ordering remains unchanged with this commit. Cc: Matthias Brugger Cc: Sascha Hauer Cc: Daniel Kurtz Cc: Paul Gortmaker Cc: Olof Johansson Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org Cc: linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org Signed-off-by: Paul Gortmaker diff --git a/drivers/soc/mediatek/mtk-scpsys.c b/drivers/soc/mediatek/mtk-scpsys.c index 164a7d8439b1..ae0ca34e64dd 100644 --- a/drivers/soc/mediatek/mtk-scpsys.c +++ b/drivers/soc/mediatek/mtk-scpsys.c @@ -15,7 +15,7 @@ #include #include #include -#include +#include #include #include #include @@ -484,5 +484,4 @@ static struct platform_driver scpsys_drv = { .of_match_table = of_match_ptr(of_scpsys_match_tbl), }, }; - -module_platform_driver_probe(scpsys_drv, scpsys_probe); +builtin_platform_driver_probe(scpsys_drv, scpsys_probe); -- 2.5.0 From mboxrd@z Thu Jan 1 00:00:00 1970 From: paul.gortmaker@windriver.com (Paul Gortmaker) Date: Thu, 17 Dec 2015 10:16:17 -0500 Subject: [PATCH v2] soc: mediatek: SCPSYS: use module_platform_driver In-Reply-To: References: <1450263656-12513-1-git-send-email-s.hauer@pengutronix.de> <1562792.sV6cmsyeOM@wuerfel> <56715136.3060908@gmail.com> Message-ID: <20151217151617.GY2772@windriver.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org [Re: [PATCH v2] soc: mediatek: SCPSYS: use module_platform_driver] On 17/12/2015 (Thu 10:52) Daniel Kurtz wrote: [...] > > Also, since scpsys' Kconfig is "bool" not "tristate" it isn't a real > module so I think we should use: > builtin_platform_driver not module_platform_driver > > CC'ing Paul Gortmaker who seems to be on a mass > builtin_platform_driver conversion at the moment, see: > https://lkml.org/lkml/2015/12/9/952 > Good guess. In my giant queue I have that change. I just haven't got around to the requisite triple check and multi arch rebuild tests and put out a series for soc yet. Here is the short list for soc: drivers-soc-make-mediatek-mtk-scpsys.c-explicitly-no.patch drivers-soc-make-qcom-spm.c-explicitly-non-modular.patch drivers-soc-make-samsung-exynos-srom.c.c-explicitly-.patch drivers-soc-make-sunxi_sram.c-explicitly-non-modular.patch drivers-soc-tegra-make-fuse-tegra.c-explicitly-non-m.patch ...and here is the patch you predicted. If someone wants to fold the change into their work then great; I'll be happy to drop mine and be with one less patch to herd along. Paul. -- From eb32cc2c1db8192c08dd64af69cb172b3be4c98b Mon Sep 17 00:00:00 2001 From: Paul Gortmaker Date: Fri, 4 Sep 2015 19:33:54 -0400 Subject: [PATCH] drivers/soc: make mediatek/mtk-scpsys.c explicitly non-modular The Kconfig currently controlling compilation of this code is: drivers/soc/mediatek/Kconfig:config MTK_SCPSYS drivers/soc/mediatek/Kconfig: bool "MediaTek SCPSYS Support" ...meaning that it currently is not being built as a module by anyone. Lets remove the couple traces of modularity so that when reading the driver there is no doubt it is builtin-only. Since module_platform_driver() uses the same init level priority as builtin_platform_driver() the init ordering remains unchanged with this commit. Cc: Matthias Brugger Cc: Sascha Hauer Cc: Daniel Kurtz Cc: Paul Gortmaker Cc: Olof Johansson Cc: linux-arm-kernel at lists.infradead.org Cc: linux-mediatek at lists.infradead.org Signed-off-by: Paul Gortmaker diff --git a/drivers/soc/mediatek/mtk-scpsys.c b/drivers/soc/mediatek/mtk-scpsys.c index 164a7d8439b1..ae0ca34e64dd 100644 --- a/drivers/soc/mediatek/mtk-scpsys.c +++ b/drivers/soc/mediatek/mtk-scpsys.c @@ -15,7 +15,7 @@ #include #include #include -#include +#include #include #include #include @@ -484,5 +484,4 @@ static struct platform_driver scpsys_drv = { .of_match_table = of_match_ptr(of_scpsys_match_tbl), }, }; - -module_platform_driver_probe(scpsys_drv, scpsys_probe); +builtin_platform_driver_probe(scpsys_drv, scpsys_probe); -- 2.5.0