Re: [Qemu-devel] [PULL v1 0/9] Introduce I/O channels framework

["Daniel P. Berrange" <berrange@redhat.com>]

On Thu, Dec 17, 2015 at 03:04:33PM +0000, Peter Maydell wrote:
> On 17 December 2015 at 13:45, Daniel P. Berrange <berrange@redhat.com> wrote:
> > The following changes since commit c1a5f950cdeeaea6a835b2b33f040a0e62c18662:
> >
> >   Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2015-12-17' into staging (2015-12-17 11:50:46 +0000)
> >
> > are available in the git repository at:
> >
> >   git://github.com/berrange/qemu tags/pull-io-channel-base-2015-12-17-1
> >
> > for you to fetch changes up to 37c41c79730f7535c54f304e5c6e89fbf2cfe0e5:
> >
> >   io: add QIOChannelBuffer class (2015-12-17 13:26:04 +0000)
> >
> > ----------------------------------------------------------------
> > Merge I/O channels base classes
> >
> > ----------------------------------------------------------------
> > Daniel P. Berrange (9):
> >       io: add abstract QIOChannel classes
> >       io: add helper module for creating watches on FDs
> >       io: add QIOTask class for async operations
> >       io: add QIOChannelSocket class
> >       io: add QIOChannelFile class
> >       io: add QIOChannelTLS class
> >       io: add QIOChannelWebsock class
> >       io: add QIOChannelCommand class
> >       io: add QIOChannelBuffer class
> 
> Hi. I'm afraid this fails to build on OSX:
> 
> In file included from /Users/pm215/src/qemu-for-merges/io/channel.c:21:
> /Users/pm215/src/qemu-for-merges/include/io/channel.h:127:5: error:
> type name requires a specifier or qualifier
>     off64_t (*io_seek)(QIOChannel *ioc,

[snip]

> 1 warning and 9 errors generated.

Ok, will repost with  s/off_t/off64_t/ since QEMU builds with
-D_FILE_OFFSET_BITS=64 meaning both off_t and off64_t are the
same size anyway.


Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|