From: Stephen Hemminger <shemming@brocade.com>
To: Paolo Abeni <pabeni@redhat.com>
Cc: <netdev@vger.kernel.org>, Roopa Prabhu <roopa@cumulusnetworks.com>
Subject: Re: [PATCH iproute2] lwtunnel: fix argument parsing
Date: Thu, 17 Dec 2015 17:16:31 -0800 [thread overview]
Message-ID: <20151217171631.4ea010c0@xeon-e3> (raw)
In-Reply-To: <f105b591ec43f65607f9d08d46af4612bb75e8cd.1450178247.git.pabeni@redhat.com>
On Tue, 15 Dec 2015 12:18:04 +0100
Paolo Abeni <pabeni@redhat.com> wrote:
> Currently parse_encap_ip() does not update correctly argv/argc;
> if multiple lwtunnel arguments are provided, the parsing fails after
> the first one, i.e.
>
> ip route add 172.16.101.0/24 dev vxlan1 encap ip id 42 dst 192.168.255.1
>
> fails with:
>
> Error: either "to" is duplicate, or "dst" is a garbage.
>
> This commit addresses the issue, stepping to next argument at each iteration
> of the parsing loop.
>
> Fixes: 1e5293056a02 ("lwtunnel: Add encapsulation support to ip route")
> Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Applied, thanks
prev parent reply other threads:[~2015-12-18 1:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-15 11:18 [PATCH iproute2] lwtunnel: fix argument parsing Paolo Abeni
2015-12-18 1:16 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151217171631.4ea010c0@xeon-e3 \
--to=shemming@brocade.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=roopa@cumulusnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.