All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Brown <david.brown@linaro.org>
To: kernel-hardening@lists.openwall.com
Cc: David Windsor <dave@progbits.org>, Kees Cook <keescook@chromium.org>
Subject: Re: [kernel-hardening][RFC PATCH 5/5] lkdtm: add test for atomic_t underflow/overflow
Date: Thu, 17 Dec 2015 13:55:32 -0800	[thread overview]
Message-ID: <20151217215532.GA64407@davidb.org> (raw)
In-Reply-To: <1450331796-10329-6-git-send-email-dave@progbits.org>

On Thu, Dec 17, 2015 at 12:56:36AM -0500, David Windsor wrote:

>diff --git a/drivers/misc/lkdtm.c b/drivers/misc/lkdtm.c
>index b5abe34..5002747 100644
>--- a/drivers/misc/lkdtm.c
>+++ b/drivers/misc/lkdtm.c
>@@ -104,6 +104,7 @@ enum ctype {
> 	CT_ACCESS_USERSPACE,
> 	CT_WRITE_RO,
> 	CT_WRITE_KERN,
>+    CT_WRAP_ATOMIC
> };
>
> static char* cp_name[] = {

You seem to be indenting with spaces rather than tabs.  It'd probably
be a good idea to run checkpatch on the patches.  It should catch
this.

David

      reply	other threads:[~2015-12-17 21:55 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-17  5:56 [kernel-hardening][RFC PATCH 0/5] Add PAX_REFCOUNT overflow protection David Windsor
2015-12-17  5:56 ` [kernel-hardening][RFC PATCH 1/5] x86: add PAX_REFCOUNT support David Windsor
2015-12-17  5:56 ` [kernel-hardening][RFC PATCH 2/5] percpu_ref: decrease per-CPU refcount bias David Windsor
2015-12-17  5:56 ` [kernel-hardening][RFC PATCH 4/5] security: add Kconfig options for PAX_REFCOUNT David Windsor
2015-12-17  5:56 ` [kernel-hardening][RFC PATCH 5/5] lkdtm: add test for atomic_t underflow/overflow David Windsor
2015-12-17 21:55   ` David Brown [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151217215532.GA64407@davidb.org \
    --to=david.brown@linaro.org \
    --cc=dave@progbits.org \
    --cc=keescook@chromium.org \
    --cc=kernel-hardening@lists.openwall.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.