All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vinod Koul <vinod.koul@intel.com>
To: Martin Sperl <kernel@martin.sperl.org>
Cc: dmaengine@vger.kernel.org,
	"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
	linux-rpi-kernel <linux-rpi-kernel@lists.infradead.org>,
	"Noralf Trønnes" <noralf@tronnes.org>,
	jonathan@raspberrypi.org, dan.j.williams@intel.com,
	"Eric Anholt" <eric@anholt.net>,
	"Stephen Warren" <swarren@wwwdotorg.org>,
	"Lee Jones" <lee@kernel.org>
Subject: Re: [RESEND][PATCH v2] dmaengine: bcm2835: Add slave dma support
Date: Fri, 18 Dec 2015 13:33:29 +0530	[thread overview]
Message-ID: <20151218080329.GX1854@localhost> (raw)
In-Reply-To: <54C5C021-6733-412D-8E2C-0118F786465F@martin.sperl.org>

On Fri, Dec 18, 2015 at 08:27:52AM +0100, Martin Sperl wrote:
> 
> > On 18.12.2015, at 07:05, Vinod Koul <vinod.koul@intel.com> wrote:

> > Most of this part is common with the cyclic and seems copy paste. Can we
> > use common routine to do common work please
> 
> I agree - can have a look - the big question is: how would I document the 
> individual changes by Gellert Weisz and myself correctly?
> * just a single patch with an attribution tag (which?) or just a commit message?
> * Patchset with 2 patches: the original by Gellert Weisz (this)
>   plus the modification to consolidate the code above?

There are lot of patches were original contributors moved away. In the change
log please say original written by <> and modified for upstream by you.

That way you retain credit for original changes done

Thanks
-- 
~Vinod

      reply	other threads:[~2015-12-18  8:00 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-17 18:11 [RESEND][PATCH v2] dmaengine: bcm2835: Add slave dma support Martin Sperl
2015-12-18  6:05 ` Vinod Koul
2015-12-18  7:27   ` Martin Sperl
2015-12-18  8:03     ` Vinod Koul [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151218080329.GX1854@localhost \
    --to=vinod.koul@intel.com \
    --cc=dan.j.williams@intel.com \
    --cc=dmaengine@vger.kernel.org \
    --cc=eric@anholt.net \
    --cc=jonathan@raspberrypi.org \
    --cc=kernel@martin.sperl.org \
    --cc=lee@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rpi-kernel@lists.infradead.org \
    --cc=noralf@tronnes.org \
    --cc=swarren@wwwdotorg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.