From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by yocto-www.yoctoproject.org (Postfix, from userid 118) id 2D127E00B7D; Fri, 18 Dec 2015 06:17:57 -0800 (PST) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on yocto-www.yoctoproject.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.3.1 X-Spam-HAM-Report: * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id 08473E00803 for ; Fri, 18 Dec 2015 06:17:53 -0800 (PST) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga104.fm.intel.com with ESMTP; 18 Dec 2015 06:17:53 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,446,1444719600"; d="scan'208";a="15557814" Received: from linux.intel.com ([10.23.219.25]) by fmsmga004.fm.intel.com with ESMTP; 18 Dec 2015 06:17:52 -0800 Received: from linux.intel.com (vmed.fi.intel.com [10.237.72.51]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by linux.intel.com (Postfix) with ESMTP id 8FEA56A4007; Fri, 18 Dec 2015 07:05:53 -0800 (PST) Date: Fri, 18 Dec 2015 15:46:27 +0200 From: Ed Bartosh To: sujith h Message-ID: <20151218134627.GA27311@linux.intel.com> References: MIME-Version: 1.0 In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.5.21 (2010-09-15) Cc: toaster@yoctoproject.org Subject: Re: Build cancellation from toaster X-BeenThere: toaster@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list Reply-To: ed.bartosh@linux.intel.com List-Id: Web based interface for BitBake List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Dec 2015 14:17:57 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi Sujith, Can you split your changes please? I'd suggest to at least separate backend changes from frontend ones. Having uihelper.py changes in a separate commit would be nice too. It looks like you've spotted correctly that findServerDetails is not used anywhere in bitbake code. You can remove it in a separate commit as it looks unrelated to the rest of the patch. +1 for Michael's suggestion to use build controller. On Thu, Dec 17, 2015 at 10:26:11PM +0530, sujith h wrote: > Hi, > > I have posted my changes in: > http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=sujith/toaster-build-cancel > > Kindly review my changes and let me know if I have to make changes. I would > be happy to do so. > > Thanks for all helping hand from RP, Ed, Michael, Belen and Paul. > > Thanks, > Sujith H -- Regards, Ed