From: Brian Norris <computersforpeace@gmail.com>
To: Boris Brezillon <boris.brezillon@free-electrons.com>
Cc: David Woodhouse <dwmw2@infradead.org>,
linux-mtd@lists.infradead.org, Vitaly Wool <vitalywool@gmail.com>
Subject: Re: [PATCH] mtd: nand: remove unused and buggy get_platform_nandchip() helper function
Date: Fri, 18 Dec 2015 14:33:32 -0800 [thread overview]
Message-ID: <20151218223332.GR10460@google.com> (raw)
In-Reply-To: <1450106011-25105-1-git-send-email-boris.brezillon@free-electrons.com>
On Mon, Dec 14, 2015 at 04:13:31PM +0100, Boris Brezillon wrote:
> Nobody uses the get_platform_nandchip() helper function which is supposed
> to return a pointer to a platform_nand_chip struct from an mtd_info
> pointer.
> Moreover, this function is buggy since the introduction of the plat_nand
> layer (chip->priv is now storing a pointer to an intermediate
> plat_nand_data structure allocated in plat_nand_probe(), and we have no
> way to retrieve a pointer to the provided platform_nand_chip struct from
> this plat_nand_data pointer).
>
> While we are at it, remove the useless (and buggy, since it's pointing to
> something stored on the stack) data->chip.priv assignment.
>
> Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
> Fixes: 711fdf627ce1 ("[MTD] [NAND] platform NAND driver: add driver")
> Cc: Vitaly Wool <vitalywool@gmail.com>
Applied to l2-mtd.git
prev parent reply other threads:[~2015-12-18 22:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-14 15:13 [PATCH] mtd: nand: remove unused and buggy get_platform_nandchip() helper function Boris Brezillon
2015-12-18 22:33 ` Brian Norris [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151218223332.GR10460@google.com \
--to=computersforpeace@gmail.com \
--cc=boris.brezillon@free-electrons.com \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=vitalywool@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.