From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pa0-x233.google.com ([2607:f8b0:400e:c03::233]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1aA3vv-0007Le-Mi for linux-mtd@lists.infradead.org; Fri, 18 Dec 2015 22:55:33 +0000 Received: by mail-pa0-x233.google.com with SMTP id wq6so67043449pac.1 for ; Fri, 18 Dec 2015 14:55:11 -0800 (PST) Date: Fri, 18 Dec 2015 14:55:08 -0800 From: Brian Norris To: Yao Yuan Cc: "dwmw2@infradead.org" , Xu Han , "linux-kernel@vger.kernel.org" , "linux-mtd@lists.infradead.org" Subject: Re: [PATCH v2] mtd: spi-nor: fsl-quadspi: add big-endian support Message-ID: <20151218225508.GT10460@google.com> References: <1447838008-3744-1-git-send-email-yao.yuan@freescale.com> <20151125190900.GA2959@chopperman.am.freescale.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Fri, Dec 18, 2015 at 09:12:13AM +0000, Yao Yuan wrote: > Hi Woodhouse, Norris, > > Do you have any comments for this patch? No, it looks fine. But the driver maintainer (Han) already asked you for DT binding documentation already. This is a requirement before I can merge your patch. See Documentation/devicetree/bindings/submitting-patches.txt. > Thanks for your review. > > Best Regards, > Yuan Yao > > > -----Original Message----- > > From: Han Xu [mailto:han.xu@freescale.com] > > > + q->big_endian = of_property_read_bool(np, "big-endian"); > > > > I am fine with this patch, but need document the new property with another > > patch ^^^ See here Brian