From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Date: Sat, 19 Dec 2015 09:52:08 +0530 From: Pratyush Anand To: Guenter Roeck Cc: wim@iguana.be, dyoung@redhat.com, dzickus@redhat.com, linux-watchdog@vger.kernel.org, open list Subject: Re: [PATCH V5 1/2] watchdog: Use static struct class watchdog_class in stead of pointer Message-ID: <20151219042208.GH29413@dhcppc13.redhat.com> References: <5672CD1B.40105@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5672CD1B.40105@roeck-us.net> List-ID: On 17/12/2015:06:56:27 AM, Guenter Roeck wrote: > On 12/17/2015 04:23 AM, Pratyush Anand wrote: > >We need few sysfs attributes to know different status of a watchdog device. > >To do that, we need to associate .dev_groups with watchdog_class. So > >convert it from pointer to static. > >Putting this static struct in watchdog_dev.c, so that static device > >attributes defined in that file can be attached to it. > > > >Signed-off-by: Pratyush Anand > >Suggested-by: Guenter Roeck > >Reviewed-by: Guenter Roeck > > As things evolve, I'd by now prefer to move the call to device_create() > into watchdog_dev.c, but that can wait for a follow-up patch if Wim > is ok with this series. Thanks for your quick review. OK. I will wait for Wim's comment and then may be I will send another version with your comment for patch 1/1 incorporated. ~Pratyush