All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Wills Wang <wills.wang@live.com>
Cc: jringle@gridpoint.com, linux-kernel@vger.kernel.org,
	linux-serial@vger.kernel.org
Subject: Re: [PATCH] sc16is7xx: fix incorrect register bits macro
Date: Sat, 19 Dec 2015 16:43:03 -0800	[thread overview]
Message-ID: <20151220004303.GA18048@kroah.com> (raw)
In-Reply-To: <BLU436-SMTP214949663591D40091B8468FFE20@phx.gbl>

On Sat, Dec 19, 2015 at 07:20:06PM +0800, Wills Wang wrote:
> In datasheet, Modem Status Register MSR[4-5] reflect the modem pins
> CTS/DSR/RI/CD signal state.
> 
> Signed-off-by: Wills Wang <wills.wang@live.com>
> ---
>  drivers/tty/serial/sc16is7xx.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/tty/serial/sc16is7xx.c b/drivers/tty/serial/sc16is7xx.c
> index edb5305..9d18c24 100644
> --- a/drivers/tty/serial/sc16is7xx.c
> +++ b/drivers/tty/serial/sc16is7xx.c
> @@ -196,14 +196,14 @@
>  						  * or (IO6)
>  						  * - only on 75x/76x
>  						  */
> -#define SC16IS7XX_MSR_CTS_BIT		(1 << 0) /* CTS */
> -#define SC16IS7XX_MSR_DSR_BIT		(1 << 1) /* DSR (IO4)
> +#define SC16IS7XX_MSR_CTS_BIT		(1 << 4) /* CTS */
> +#define SC16IS7XX_MSR_DSR_BIT		(1 << 5) /* DSR (IO4)

BIT(4)  BIT(5)?

Please do that at the same time...

thanks,

greg k-h

      reply	other threads:[~2015-12-20  0:43 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-19 11:20 [PATCH] sc16is7xx: fix incorrect register bits macro Wills Wang
2015-12-20  0:43 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151220004303.GA18048@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=jringle@gridpoint.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=wills.wang@live.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.