From: Christoph Hellwig <hch@infradead.org>
To: Vivek Trivedi <t.vivek@samsung.com>
Cc: a.sahrawat@samsung.com, pankaj.m@samsung.com, xfs@oss.sgi.com
Subject: Re: [PATCH v2 3/4] xfsprogs: mkfs: fix unintentional integer overflow
Date: Sun, 20 Dec 2015 07:36:49 -0800 [thread overview]
Message-ID: <20151220153649.GE20135@infradead.org> (raw)
In-Reply-To: <1449832143-26356-4-git-send-email-t.vivek@samsung.com>
> +++ b/mkfs/xfs_mkfs.c
> @@ -2022,7 +2022,7 @@ _("warning: sparse inodes not supported without CRC support, disabled.\n"));
> * and the underlying volume is striped, then set rtextblocks
> * to the stripe width.
> */
> - int rswidth;
> + __uint64_t rswidth;
> __uint64_t rtextbytes;
This looks odd. We initiallize assigned ft.rtswidth (which is an int)
or 0 to it. I think you want a separate variable for the result of
the DTOBT(rswidth) statement to make this clear.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2015-12-20 15:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-11 11:08 [PATCH v2 0/4] xfsprogs misc fixes Vivek Trivedi
2015-12-11 11:09 ` [PATCH v2 1/4] xfsprogs: xfs_io: fix a memory leak in imap_f Vivek Trivedi
2015-12-20 15:33 ` Christoph Hellwig
2015-12-20 23:48 ` Dave Chinner
2015-12-11 11:09 ` [PATCH v2 2/4] xfsprogs: fix integer overflow in xlog_find_verify_cycle Vivek Trivedi
2015-12-20 15:35 ` Christoph Hellwig
2015-12-20 23:45 ` Dave Chinner
2015-12-11 11:09 ` [PATCH v2 3/4] xfsprogs: mkfs: fix unintentional integer overflow Vivek Trivedi
2015-12-20 15:36 ` Christoph Hellwig [this message]
2015-12-20 23:51 ` Dave Chinner
2015-12-11 11:09 ` [PATCH v2 4/4] xfsprogs: xfsdb: remove unnessary checks in process_leaf_node_dir_v2_free Vivek Trivedi
2015-12-20 15:37 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151220153649.GE20135@infradead.org \
--to=hch@infradead.org \
--cc=a.sahrawat@samsung.com \
--cc=pankaj.m@samsung.com \
--cc=t.vivek@samsung.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.