diff for duplicates of <20151220203335.GX5284@mwanda> diff --git a/a/1.txt b/N1/1.txt index d5bd4a5..cc8a2b4 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -4,12 +4,12 @@ On Sun, Dec 20, 2015 at 11:05:55AM -0800, Joe Perches wrote: > > > > > On Sat, 2015-12-19 at 13:59 +0300, Dan Carpenter wrote: > > > > There is a type bug so it always returns success. -> > >? +> > > > > > How many false positives do you have to sift > > > through to find this sort of error? > > -> > The return type is thoughtfully bool, so it should be easy in this case.?? -> > The function has a return -EINVAL and a return true, so even without the? +> > The return type is thoughtfully bool, so it should be easy in this case. +> > The function has a return -EINVAL and a return true, so even without the > > return type it would be locally apparent that there is an inconsistency. > > True, -EINVAL is a non-bool constant, but @@ -26,3 +26,8 @@ There aren't many false positives. regards, dan carpenter + +-- +To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in +the body of a message to majordomo@vger.kernel.org +More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/a/content_digest b/N1/content_digest index 7129701..f9b53e6 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -3,9 +3,16 @@ "ref\0alpine.DEB.2.02.1512201959090.2055@localhost6.localdomain6\0" "ref\01450638355.3430.34.camel@perches.com\0" "From\0Dan Carpenter <dan.carpenter@oracle.com>\0" - "Subject\0[ath9k-devel] [patch -next] ath9k: fix ath9k_hw_nvram_check_version()\0" - "Date\0Sun, 20 Dec 2015 23:33:36 +0300\0" - "To\0ath9k-devel@lists.ath9k.org\0" + "Subject\0Re: [patch -next] ath9k: fix ath9k_hw_nvram_check_version()\0" + "Date\0Sun, 20 Dec 2015 20:33:36 +0000\0" + "To\0Joe Perches <joe@perches.com>\0" + "Cc\0Julia Lawall <julia.lawall@lip6.fr>" + QCA ath9k Development <ath9k-devel@qca.qualcomm.com> + Martin Blumenstingl <martin.blumenstingl@googlemail.com> + Kalle Valo <kvalo@codeaurora.org> + linux-wireless@vger.kernel.org + ath9k-devel@venema.h4ckr.net + " kernel-janitors@vger.kernel.org\0" "\00:1\0" "b\0" "On Sun, Dec 20, 2015 at 11:05:55AM -0800, Joe Perches wrote:\n" @@ -14,12 +21,12 @@ "> > \n" "> > > On Sat, 2015-12-19 at 13:59 +0300, Dan Carpenter wrote:\n" "> > > > There is a type bug so it always returns success.\n" - "> > >?\n" + "> > >\302\240\n" "> > > How many false positives do you have to sift\n" "> > > through to find this sort of error?\n" "> > \n" - "> > The return type is thoughtfully bool, so it should be easy in this case.??\n" - "> > The function has a return -EINVAL and a return true, so even without the?\n" + "> > The return type is thoughtfully bool, so it should be easy in this case.\302\240\302\240\n" + "> > The function has a return -EINVAL and a return true, so even without the\302\240\n" "> > return type it would be locally apparent that there is an inconsistency.\n" "> \n" "> True, -EINVAL is a non-bool constant, but\n" @@ -35,6 +42,11 @@ "There aren't many false positives.\n" "\n" "regards,\n" - dan carpenter + "dan carpenter\n" + "\n" + "--\n" + "To unsubscribe from this list: send the line \"unsubscribe kernel-janitors\" in\n" + "the body of a message to majordomo@vger.kernel.org\n" + More majordomo info at http://vger.kernel.org/majordomo-info.html -ecd6992adb9fcc6d70658699abf55bf706b5a7113b667ea6c256e9136b70766d +5e71edd49fffafdd599573bcda37d63db0a207ee81c5f21345ae22f2e2d16b09
diff --git a/a/1.txt b/N2/1.txt index d5bd4a5..8f61ff4 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -4,12 +4,12 @@ On Sun, Dec 20, 2015 at 11:05:55AM -0800, Joe Perches wrote: > > > > > On Sat, 2015-12-19 at 13:59 +0300, Dan Carpenter wrote: > > > > There is a type bug so it always returns success. -> > >? +> > > > > > How many false positives do you have to sift > > > through to find this sort of error? > > -> > The return type is thoughtfully bool, so it should be easy in this case.?? -> > The function has a return -EINVAL and a return true, so even without the? +> > The return type is thoughtfully bool, so it should be easy in this case. +> > The function has a return -EINVAL and a return true, so even without the > > return type it would be locally apparent that there is an inconsistency. > > True, -EINVAL is a non-bool constant, but diff --git a/a/content_digest b/N2/content_digest index 7129701..ce34728 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -3,9 +3,16 @@ "ref\0alpine.DEB.2.02.1512201959090.2055@localhost6.localdomain6\0" "ref\01450638355.3430.34.camel@perches.com\0" "From\0Dan Carpenter <dan.carpenter@oracle.com>\0" - "Subject\0[ath9k-devel] [patch -next] ath9k: fix ath9k_hw_nvram_check_version()\0" + "Subject\0Re: [patch -next] ath9k: fix ath9k_hw_nvram_check_version()\0" "Date\0Sun, 20 Dec 2015 23:33:36 +0300\0" - "To\0ath9k-devel@lists.ath9k.org\0" + "To\0Joe Perches <joe@perches.com>\0" + "Cc\0Julia Lawall <julia.lawall@lip6.fr>" + QCA ath9k Development <ath9k-devel@qca.qualcomm.com> + Martin Blumenstingl <martin.blumenstingl@googlemail.com> + Kalle Valo <kvalo@codeaurora.org> + linux-wireless@vger.kernel.org + ath9k-devel@venema.h4ckr.net + " kernel-janitors@vger.kernel.org\0" "\00:1\0" "b\0" "On Sun, Dec 20, 2015 at 11:05:55AM -0800, Joe Perches wrote:\n" @@ -14,12 +21,12 @@ "> > \n" "> > > On Sat, 2015-12-19 at 13:59 +0300, Dan Carpenter wrote:\n" "> > > > There is a type bug so it always returns success.\n" - "> > >?\n" + "> > >\302\240\n" "> > > How many false positives do you have to sift\n" "> > > through to find this sort of error?\n" "> > \n" - "> > The return type is thoughtfully bool, so it should be easy in this case.??\n" - "> > The function has a return -EINVAL and a return true, so even without the?\n" + "> > The return type is thoughtfully bool, so it should be easy in this case.\302\240\302\240\n" + "> > The function has a return -EINVAL and a return true, so even without the\302\240\n" "> > return type it would be locally apparent that there is an inconsistency.\n" "> \n" "> True, -EINVAL is a non-bool constant, but\n" @@ -37,4 +44,4 @@ "regards,\n" dan carpenter -ecd6992adb9fcc6d70658699abf55bf706b5a7113b667ea6c256e9136b70766d +89bb84c2ab50c426f16d31c6bd1b1ddfa0fe365f1b85992aa4e80cb773a500b2
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.