From: David Gibson <david@gibson.dropbear.id.au>
To: Thomas Huth <thuth@redhat.com>
Cc: qemu-ppc@nongnu.org, Alexander Graf <agraf@suse.de>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] hw/ppc/spapr_rtc: Remove bad class_size value
Date: Mon, 21 Dec 2015 11:47:05 +1100 [thread overview]
Message-ID: <20151221004705.GP3011@voom.redhat.com> (raw)
In-Reply-To: <1450429574-31028-1-git-send-email-thuth@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1070 bytes --]
On Fri, Dec 18, 2015 at 10:06:14AM +0100, Thomas Huth wrote:
> class_size = sizeof(XICSStateClass) does not make much sense
> in the RTC code and likely was just a copy-n-paste error.
> Let's simply remove it.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
Oops, that's an embarrasing error. Fix applied to ppc-for-2.5 and ppc-for-2.6
> ---
> hw/ppc/spapr_rtc.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/hw/ppc/spapr_rtc.c b/hw/ppc/spapr_rtc.c
> index 34b27db..b591a8e 100644
> --- a/hw/ppc/spapr_rtc.c
> +++ b/hw/ppc/spapr_rtc.c
> @@ -200,7 +200,6 @@ static const TypeInfo spapr_rtc_info = {
> .name = TYPE_SPAPR_RTC,
> .parent = TYPE_SYS_BUS_DEVICE,
> .instance_size = sizeof(sPAPRRTCState),
> - .class_size = sizeof(XICSStateClass),
> .class_init = spapr_rtc_class_init,
> };
>
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2015-12-21 0:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-18 9:06 [Qemu-devel] [PATCH] hw/ppc/spapr_rtc: Remove bad class_size value Thomas Huth
2015-12-21 0:47 ` David Gibson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151221004705.GP3011@voom.redhat.com \
--to=david@gibson.dropbear.id.au \
--cc=agraf@suse.de \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.