From: Borislav Petkov <bp@alien8.de>
To: Bryan O'Donoghue <pure.logic@nexus-software.ie>
Cc: "Kweh, Hock Leong" <hock.leong.kweh@intel.com>,
Matt Fleming <matt@console-pimps.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Matt Fleming <matt@codeblueprint.co.uk>,
Ong Boon Leong <boon.leong.ong@intel.com>,
LKML <linux-kernel@vger.kernel.org>,
linux-efi@vger.kernel.org,
Sam Protsenko <semen.protsenko@linaro.org>,
Peter Jones <pjones@redhat.com>,
Andy Lutomirski <luto@amacapital.net>,
Roy Franz <roy.franz@linaro.org>,
James Bottomley <James.Bottomley@hansenpartnership.com>,
Linux FS Devel <linux-fsdevel@vger.kernel.org>,
Anvin H Peter <h.peter.anvin@intel.com>
Subject: Re: [PATCH v10 1/1] efi: a misc char interface for user to update efi firmware
Date: Mon, 21 Dec 2015 18:37:15 +0100 [thread overview]
Message-ID: <20151221173715.GE21582@pd.tnic> (raw)
In-Reply-To: <1450717451.8767.69.camel@nexus-software.ie>
On Mon, Dec 21, 2015 at 05:04:11PM +0000, Bryan O'Donoghue wrote:
> > This patch also export efi_capsule_supported() function symbol for
> > verifying the submitted capsule header in this kernel module.
>
> 1. Should be a separate patch
> 2. Suggested, rewording for that patch log
>
> 2/2 Title
> This patch exports efi_capsule_supported to enable verification of the
> capsule header.
>
> That said - who is the user of this symbol ? Why is it needed ? Anyway
> please consider splitting and rewording.
Huh?
I still don't really see the reasoning for splitting out the export.
When you do the export and use it in a single patch it is *obvious* why
it is being exported.
And there's no need to mention in the commit message that you're
exporting a symbol. People export symbols all the time.
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
next prev parent reply other threads:[~2015-12-21 17:37 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-18 12:13 [PATCH v10 0/1] Enable capsule loader interface for efi firmware updating Kweh, Hock Leong
[not found] ` <1450440782-5446-1-git-send-email-hock.leong.kweh-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-12-18 12:13 ` [PATCH v10 1/1] efi: a misc char interface for user to update efi firmware Kweh, Hock Leong
2015-12-18 12:13 ` Kweh, Hock Leong
2015-12-21 17:04 ` Bryan O'Donoghue
2015-12-21 17:37 ` Borislav Petkov [this message]
2015-12-21 17:45 ` Bryan O'Donoghue
2016-01-21 12:35 ` Matt Fleming
[not found] ` <1450440782-5446-2-git-send-email-hock.leong.kweh-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-01-21 11:51 ` Matt Fleming
2016-01-21 11:51 ` Matt Fleming
-- strict thread matches above, loose matches on Subject: below --
2016-01-26 3:09 Kweh, Hock Leong
2016-01-26 3:09 ` Kweh, Hock Leong
2016-01-26 3:10 Kweh, Hock Leong
[not found] ` <F54AEECA5E2B9541821D670476DAE19C4A8ABF06-j2khPEwRog0FyVwBAnZdSLfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2016-01-28 12:16 ` Matt Fleming
2016-01-28 12:16 ` Matt Fleming
2016-01-29 1:22 Kweh, Hock Leong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151221173715.GE21582@pd.tnic \
--to=bp@alien8.de \
--cc=James.Bottomley@hansenpartnership.com \
--cc=boon.leong.ong@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=h.peter.anvin@intel.com \
--cc=hock.leong.kweh@intel.com \
--cc=linux-efi@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=matt@codeblueprint.co.uk \
--cc=matt@console-pimps.org \
--cc=pjones@redhat.com \
--cc=pure.logic@nexus-software.ie \
--cc=roy.franz@linaro.org \
--cc=semen.protsenko@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.