From mboxrd@z Thu Jan 1 00:00:00 1970 From: "ira.weiny" Subject: Re: [PATCH 2/3] Specify attribute_id in port_table_attribute Date: Mon, 21 Dec 2015 12:43:08 -0500 Message-ID: <20151221174308.GH3860@phlsvsds.ph.intel.com> References: <20151221142026.238104419@linux.com> <20151221142039.281989535@linux.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20151221142039.281989535-vYTEC60ixJUAvxtiuMwx3w@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Christoph Lameter Cc: Hal Rosenstock , Hal Rosenstock , dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Jason Gunthorpe List-Id: linux-rdma@vger.kernel.org On Mon, Dec 21, 2015 at 08:20:28AM -0600, Christoph Lameter wrote: > Add the attr_id on port_table_attribute since we will have to add > a different port_table_attribute for the extended attribute soon. > > Reviewed-by: Hal Rosenstock Reviewed-by: Ira Weiny > Signed-off-by: Christoph Lameter > --- > drivers/infiniband/core/sysfs.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/drivers/infiniband/core/sysfs.c b/drivers/infiniband/core/sysfs.c > index acefe85..34dcc23 100644 > --- a/drivers/infiniband/core/sysfs.c > +++ b/drivers/infiniband/core/sysfs.c > @@ -39,6 +39,7 @@ > #include > > #include > +#include > > struct ib_port { > struct kobject kobj; > @@ -65,6 +66,7 @@ struct port_table_attribute { > struct port_attribute attr; > char name[8]; > int index; > + int attr_id; > }; > > static ssize_t port_attr_show(struct kobject *kobj, > @@ -314,7 +316,8 @@ static ssize_t show_port_pkey(struct ib_port *p, struct port_attribute *attr, > #define PORT_PMA_ATTR(_name, _counter, _width, _offset) \ > struct port_table_attribute port_pma_attr_##_name = { \ > .attr = __ATTR(_name, S_IRUGO, show_pma_counter, NULL), \ > - .index = (_offset) | ((_width) << 16) | ((_counter) << 24) \ > + .index = (_offset) | ((_width) << 16) | ((_counter) << 24), \ > + .attr_id = IB_PMA_PORT_COUNTERS , \ > } > > /* > @@ -376,7 +379,7 @@ static ssize_t show_pma_counter(struct ib_port *p, struct port_attribute *attr, > ssize_t ret; > u8 data[8]; > > - ret = get_perf_mad(p->ibdev, p->port_num, cpu_to_be16(0x12), &data, > + ret = get_perf_mad(p->ibdev, p->port_num, tab_attr->attr_id, &data, > 40 + offset / 8, sizeof(data)); > if (ret < 0) > return sprintf(buf, "N/A (no PMA)\n"); > -- > 2.5.0 > > -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html