From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ross Zwisler Subject: Re: [PATCH v5 2/7] dax: support dirty DAX entries in radix tree Date: Mon, 21 Dec 2015 10:45:34 -0700 Message-ID: <20151221174534.GA4978@linux.intel.com> References: <1450502540-8744-1-git-send-email-ross.zwisler@linux.intel.com> <1450502540-8744-3-git-send-email-ross.zwisler@linux.intel.com> <20151221171512.GA7030@quack.suse.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Ross Zwisler , linux-kernel@vger.kernel.org, "H. Peter Anvin" , "J. Bruce Fields" , Theodore Ts'o , Alexander Viro , Andreas Dilger , Dave Chinner , Ingo Molnar , Jan Kara , Jeff Layton , Matthew Wilcox , Thomas Gleixner , linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-nvdimm@lists.01.org, x86@kernel.org, xfs@oss.sgi.com, Andrew Morton , Dan Williams , Matthew Wilcox , Dave Hansen To: Jan Kara Return-path: Content-Disposition: inline In-Reply-To: <20151221171512.GA7030@quack.suse.cz> Sender: owner-linux-mm@kvack.org List-Id: linux-ext4.vger.kernel.org On Mon, Dec 21, 2015 at 06:15:12PM +0100, Jan Kara wrote: > On Fri 18-12-15 22:22:15, Ross Zwisler wrote: > > Add support for tracking dirty DAX entries in the struct address_space > > radix tree. This tree is already used for dirty page writeback, and it > > already supports the use of exceptional (non struct page*) entries. > > > > In order to properly track dirty DAX pages we will insert new exceptional > > entries into the radix tree that represent dirty DAX PTE or PMD pages. > > These exceptional entries will also contain the writeback addresses for the > > PTE or PMD faults that we can use at fsync/msync time. > > > > There are currently two types of exceptional entries (shmem and shadow) > > that can be placed into the radix tree, and this adds a third. We rely on > > the fact that only one type of exceptional entry can be found in a given > > radix tree based on its usage. This happens for free with DAX vs shmem but > > we explicitly prevent shadow entries from being added to radix trees for > > DAX mappings. > > > > The only shadow entries that would be generated for DAX radix trees would > > be to track zero page mappings that were created for holes. These pages > > would receive minimal benefit from having shadow entries, and the choice > > to have only one type of exceptional entry in a given radix tree makes the > > logic simpler both in clear_exceptional_entry() and in the rest of DAX. > > > > Signed-off-by: Ross Zwisler > > The patch looks good to me. Just one comment: When we have this exclusion > between different types of exceptional entries, there is no real need to > have separate counters of 'shadow' and 'dax' entries, is there? We can have > one 'nrexceptional' counter and don't have to grow struct inode > unnecessarily which would be really welcome since DAX isn't a mainstream > feature. Could you please change the code? Thanks! Sure, this sounds good. Thanks! -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay2.corp.sgi.com [137.38.102.29]) by oss.sgi.com (Postfix) with ESMTP id BC5CC7F37 for ; Mon, 21 Dec 2015 11:46:25 -0600 (CST) Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by relay2.corp.sgi.com (Postfix) with ESMTP id 9953530404E for ; Mon, 21 Dec 2015 09:46:25 -0800 (PST) Received: from mga14.intel.com ([192.55.52.115]) by cuda.sgi.com with ESMTP id pvjJOEjgyKwVzmbg for ; Mon, 21 Dec 2015 09:46:23 -0800 (PST) Date: Mon, 21 Dec 2015 10:45:34 -0700 From: Ross Zwisler Subject: Re: [PATCH v5 2/7] dax: support dirty DAX entries in radix tree Message-ID: <20151221174534.GA4978@linux.intel.com> References: <1450502540-8744-1-git-send-email-ross.zwisler@linux.intel.com> <1450502540-8744-3-git-send-email-ross.zwisler@linux.intel.com> <20151221171512.GA7030@quack.suse.cz> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20151221171512.GA7030@quack.suse.cz> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Jan Kara Cc: Dave Hansen , "J. Bruce Fields" , linux-mm@kvack.org, Andreas Dilger , "H. Peter Anvin" , Jeff Layton , Dan Williams , linux-nvdimm@lists.01.org, x86@kernel.org, Ingo Molnar , Matthew Wilcox , Ross Zwisler , linux-ext4@vger.kernel.org, xfs@oss.sgi.com, Alexander Viro , Thomas Gleixner , Theodore Ts'o , linux-kernel@vger.kernel.org, Jan Kara , linux-fsdevel@vger.kernel.org, Andrew Morton , Matthew Wilcox On Mon, Dec 21, 2015 at 06:15:12PM +0100, Jan Kara wrote: > On Fri 18-12-15 22:22:15, Ross Zwisler wrote: > > Add support for tracking dirty DAX entries in the struct address_space > > radix tree. This tree is already used for dirty page writeback, and it > > already supports the use of exceptional (non struct page*) entries. > > > > In order to properly track dirty DAX pages we will insert new exceptional > > entries into the radix tree that represent dirty DAX PTE or PMD pages. > > These exceptional entries will also contain the writeback addresses for the > > PTE or PMD faults that we can use at fsync/msync time. > > > > There are currently two types of exceptional entries (shmem and shadow) > > that can be placed into the radix tree, and this adds a third. We rely on > > the fact that only one type of exceptional entry can be found in a given > > radix tree based on its usage. This happens for free with DAX vs shmem but > > we explicitly prevent shadow entries from being added to radix trees for > > DAX mappings. > > > > The only shadow entries that would be generated for DAX radix trees would > > be to track zero page mappings that were created for holes. These pages > > would receive minimal benefit from having shadow entries, and the choice > > to have only one type of exceptional entry in a given radix tree makes the > > logic simpler both in clear_exceptional_entry() and in the rest of DAX. > > > > Signed-off-by: Ross Zwisler > > The patch looks good to me. Just one comment: When we have this exclusion > between different types of exceptional entries, there is no real need to > have separate counters of 'shadow' and 'dax' entries, is there? We can have > one 'nrexceptional' counter and don't have to grow struct inode > unnecessarily which would be really welcome since DAX isn't a mainstream > feature. Could you please change the code? Thanks! Sure, this sounds good. Thanks! _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751938AbbLURq3 (ORCPT ); Mon, 21 Dec 2015 12:46:29 -0500 Received: from mga14.intel.com ([192.55.52.115]:21450 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751815AbbLURqX (ORCPT ); Mon, 21 Dec 2015 12:46:23 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,460,1444719600"; d="scan'208";a="878371481" Date: Mon, 21 Dec 2015 10:45:34 -0700 From: Ross Zwisler To: Jan Kara Cc: Ross Zwisler , linux-kernel@vger.kernel.org, "H. Peter Anvin" , "J. Bruce Fields" , "Theodore Ts'o" , Alexander Viro , Andreas Dilger , Dave Chinner , Ingo Molnar , Jan Kara , Jeff Layton , Matthew Wilcox , Thomas Gleixner , linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-nvdimm@ml01.01.org, x86@kernel.org, xfs@oss.sgi.com, Andrew Morton , Dan Williams , Matthew Wilcox , Dave Hansen Subject: Re: [PATCH v5 2/7] dax: support dirty DAX entries in radix tree Message-ID: <20151221174534.GA4978@linux.intel.com> Mail-Followup-To: Ross Zwisler , Jan Kara , linux-kernel@vger.kernel.org, "H. Peter Anvin" , "J. Bruce Fields" , Theodore Ts'o , Alexander Viro , Andreas Dilger , Dave Chinner , Ingo Molnar , Jan Kara , Jeff Layton , Matthew Wilcox , Thomas Gleixner , linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-nvdimm@lists.01.org, x86@kernel.org, xfs@oss.sgi.com, Andrew Morton , Dan Williams , Matthew Wilcox , Dave Hansen References: <1450502540-8744-1-git-send-email-ross.zwisler@linux.intel.com> <1450502540-8744-3-git-send-email-ross.zwisler@linux.intel.com> <20151221171512.GA7030@quack.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151221171512.GA7030@quack.suse.cz> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 21, 2015 at 06:15:12PM +0100, Jan Kara wrote: > On Fri 18-12-15 22:22:15, Ross Zwisler wrote: > > Add support for tracking dirty DAX entries in the struct address_space > > radix tree. This tree is already used for dirty page writeback, and it > > already supports the use of exceptional (non struct page*) entries. > > > > In order to properly track dirty DAX pages we will insert new exceptional > > entries into the radix tree that represent dirty DAX PTE or PMD pages. > > These exceptional entries will also contain the writeback addresses for the > > PTE or PMD faults that we can use at fsync/msync time. > > > > There are currently two types of exceptional entries (shmem and shadow) > > that can be placed into the radix tree, and this adds a third. We rely on > > the fact that only one type of exceptional entry can be found in a given > > radix tree based on its usage. This happens for free with DAX vs shmem but > > we explicitly prevent shadow entries from being added to radix trees for > > DAX mappings. > > > > The only shadow entries that would be generated for DAX radix trees would > > be to track zero page mappings that were created for holes. These pages > > would receive minimal benefit from having shadow entries, and the choice > > to have only one type of exceptional entry in a given radix tree makes the > > logic simpler both in clear_exceptional_entry() and in the rest of DAX. > > > > Signed-off-by: Ross Zwisler > > The patch looks good to me. Just one comment: When we have this exclusion > between different types of exceptional entries, there is no real need to > have separate counters of 'shadow' and 'dax' entries, is there? We can have > one 'nrexceptional' counter and don't have to grow struct inode > unnecessarily which would be really welcome since DAX isn't a mainstream > feature. Could you please change the code? Thanks! Sure, this sounds good. Thanks!