From: Stephen Hemminger <stephen@networkplumber.org>
To: Lorenzo Colitti <lorenzo@google.com>
Cc: netdev@vger.kernel.org, eric.dumazet@gmail.com, zenczykowski@gmail.com
Subject: Re: [iproute PATCH v2 2/2] ss: support closing inet sockets via SOCK_DESTROY.
Date: Mon, 21 Dec 2015 21:42:22 -0800 [thread overview]
Message-ID: <20151221214222.5ee87383@xeon-e3> (raw)
In-Reply-To: <1450358538-134898-2-git-send-email-lorenzo@google.com>
On Thu, 17 Dec 2015 22:22:18 +0900
Lorenzo Colitti <lorenzo@google.com> wrote:
> diff --git a/misc/ss.c b/misc/ss.c
> index 0dab32c..be70c41 100644
> --- a/misc/ss.c
> +++ b/misc/ss.c
> @@ -160,6 +160,9 @@ struct filter
> int states;
> int families;
> struct ssfilter *f;
> + struct {
> + __u8 kill:1;
> + } action;
> };
>
> stati
Please just make it a boolean or integer, not a structure wrapped around a bit field.
If you need to extend in the future then change it then. Please don't write code
based on speculative future additions.
next prev parent reply other threads:[~2015-12-22 5:42 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-17 13:22 [iproute PATCH v2 1/2] libnetlink: add a variant of rtnl_send_check that consumes ACKs Lorenzo Colitti
2015-12-17 13:22 ` [iproute PATCH v2 2/2] ss: support closing inet sockets via SOCK_DESTROY Lorenzo Colitti
2015-12-17 15:29 ` Eric Dumazet
2015-12-22 5:42 ` Stephen Hemminger [this message]
2015-12-22 8:31 ` Lorenzo Colitti
2015-12-22 8:31 ` [iproute PATCH v3 1/2] libnetlink: add a variant of rtnl_send_check that consumes ACKs Lorenzo Colitti
2015-12-23 21:17 ` Stephen Hemminger
2015-12-22 8:31 ` [iproute PATCH v3 2/2] ss: support closing inet sockets via SOCK_DESTROY Lorenzo Colitti
2015-12-30 20:34 ` Stephen Hemminger
2016-01-04 1:54 ` Lorenzo Colitti
2016-01-08 8:32 ` Lorenzo Colitti
2016-01-08 8:32 ` [iproute PATCH v4 1/2] libnetlink: don't print NETLINK_SOCK_DIAG errors in rtnl_talk Lorenzo Colitti
2016-01-08 8:32 ` [iproute PATCH v4 2/2] ss: support closing inet sockets via SOCK_DESTROY Lorenzo Colitti
2016-01-18 19:48 ` Stephen Hemminger
2015-12-22 8:35 ` [iproute PATCH v2 " Lorenzo Colitti
2015-12-17 16:07 ` [iproute PATCH v2 1/2] libnetlink: add a variant of rtnl_send_check that consumes ACKs Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151221214222.5ee87383@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=eric.dumazet@gmail.com \
--cc=lorenzo@google.com \
--cc=netdev@vger.kernel.org \
--cc=zenczykowski@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.