From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: James Simmons <jsimmons@infradead.org>
Cc: devel@driverdev.osuosl.org, Oleg Drokin <oleg.drokin@intel.com>,
Andreas Dilger <andreas.dilger@intel.com>,
James Simmons <uja.ornl@gmail.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
lustre-devel@lists.lustre.org
Subject: Re: [PATCH] staging: lustre: Handle nodemask on UMP machines
Date: Mon, 21 Dec 2015 14:08:25 -0800 [thread overview]
Message-ID: <20151221220825.GC14211@kroah.com> (raw)
In-Reply-To: <1447000500-29427-2-git-send-email-jsimmons@infradead.org>
On Sun, Nov 08, 2015 at 11:34:55AM -0500, James Simmons wrote:
> For UMP and SMP machines the struct cfs_cpt_table are
> defined differently. In the case handled by this patch
> nodemask is defined as a integer for the UMP case and
> as a pointer for the SMP case. This will cause a problem
> for ost_setup which reads the nodemask directly. Instead
> we create a UMP version of cfs_cpt_nodemask and use that
> in ost_setup.
>
> Signed-off-by: James Simmons <uja.ornl@gmail.com>
> Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4199
> Reviewed-on: http://review.whamcloud.com/9219
> Reviewed-by: Liang Zhen <liang.zhen@intel.com>
> Reviewed-by: Li Xi <pkuelelixi@gmail.com>
> Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
>
> Starting in 3.14 kernels nodemask_t was changed from a
> a unsigned long to a linux bitmap so more than 32 cores
> could be supported. Using set_bit in cfs_cpt_table_alloc
> no longer compiles so this patch backports bits of the
> node management function that use a linux bitmap back
> end. Cleaned up libcfs bitmap.h to use the libcfs layers
> memory allocation function. This was pulling in lustre
> related code that was not defined.
>
> Signed-off-by: James Simmons <uja.ornl@gmail.com>
> Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4993
> Reviewed-on: http://review.whamcloud.com/10332
> Reviewed-by: Liang Zhen <liang.zhen@intel.com>
> Reviewed-by: Bob Glossman <bob.glossman@intel.com>
> Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
What is with this crazy two sections of signed-off-by? If this was 2
patches, make it two patches.
If not, then don't do this.
Also, this whole series had no numbering, so I don't know how to apply
them, please fix and resend it.
thanks,
greg k-h
next prev parent reply other threads:[~2015-12-21 22:08 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-08 16:34 [lustre-devel] [PATCH v2] staging: lustre: remove IOC_LIBCFS_PING_TEST ioctl James Simmons
2015-11-08 16:34 ` James Simmons
2015-11-08 16:34 ` [lustre-devel] [PATCH] staging: lustre: Handle nodemask on UMP machines James Simmons
2015-11-08 16:34 ` James Simmons
2015-11-09 11:19 ` [lustre-devel] " Sudip Mukherjee
2015-11-09 11:19 ` Sudip Mukherjee
2015-11-10 0:46 ` [lustre-devel] " Simmons, James A.
2015-11-10 0:46 ` Simmons, James A.
2015-12-21 22:08 ` Greg Kroah-Hartman [this message]
2015-12-22 0:30 ` Dilger, Andreas
2015-11-08 16:34 ` [lustre-devel] [PATCH] staging: lustre: add sparse locking annotations James Simmons
2015-11-08 16:34 ` James Simmons
2015-11-08 16:34 ` [lustre-devel] [PATCH] staging: lustre: added debugging ability for LFSCK James Simmons
2015-11-08 16:34 ` James Simmons
2015-11-08 16:34 ` [lustre-devel] [PATCH] staging: lustre: enum lu_object_header_flags comma style fix James Simmons
2015-11-08 16:34 ` James Simmons
2015-11-08 16:34 ` [lustre-devel] [PATCH] staging: lustre: export cfs_str2mask James Simmons
2015-11-08 16:34 ` James Simmons
2015-11-09 11:08 ` [lustre-devel] " Drokin, Oleg
2015-11-09 11:08 ` Drokin, Oleg
2015-11-10 0:44 ` Simmons, James A.
2015-11-10 0:44 ` Simmons, James A.
2015-12-21 22:05 ` Greg Kroah-Hartman
2015-11-08 16:35 ` [lustre-devel] [PATCH] staging: lustre: add libcfs version of cfs_strrstr James Simmons
2015-11-08 16:35 ` James Simmons
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151221220825.GC14211@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=andreas.dilger@intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=jsimmons@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lustre-devel@lists.lustre.org \
--cc=oleg.drokin@intel.com \
--cc=uja.ornl@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.