From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752568AbbLUXEm (ORCPT ); Mon, 21 Dec 2015 18:04:42 -0500 Received: from mail-pa0-f53.google.com ([209.85.220.53]:34739 "EHLO mail-pa0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752473AbbLUXEj (ORCPT ); Mon, 21 Dec 2015 18:04:39 -0500 Date: Mon, 21 Dec 2015 15:04:39 -0800 From: Adam Barth To: trivial@kernel.org Cc: linux-kernel@vger.kernel.org Subject: [PATCH v2] lib: radix_tree: Fix error in docs about locks Message-ID: <20151221230437.GA8021@deepzen> Reply-To: 20151221082344.GA2969@deepzen MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This text refers to the "first 7 functions", which was correct when written but became incorrect when Johannes Weiner added another function to the list in 139e561660fe ("lib: radix_tree: tree node interface"). Remove the sentence because it doesn't add any additional information and would need to be updated each time the list changes. Signed-off-by: Adam Barth --- Changes in v2: - Removed the sentence entirely, as suggested by derRichard. include/linux/radix-tree.h | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/include/linux/radix-tree.h b/include/linux/radix-tree.h index 33170db..204aa02 100644 --- a/include/linux/radix-tree.h +++ b/include/linux/radix-tree.h @@ -154,10 +154,9 @@ do { \ * radix_tree_gang_lookup_tag_slot * radix_tree_tagged * - * The first 7 functions are able to be called locklessly, using RCU. The - * caller must ensure calls to these functions are made within rcu_read_lock() - * regions. Other readers (lock-free or otherwise) and modifications may be - * running concurrently. + * The caller must ensure calls to these functions (other than + * radix_tree_tagged) are made within rcu_read_lock() regions. Other readers + * (lock-free or otherwise) and modifications may be running concurrently. * * It is still required that the caller manage the synchronization and lifetimes * of the items. So if RCU lock-free lookups are used, typically this would mean -- 1.9.1