From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH v5 3/5] PCI: qcom: Add Qualcomm PCIe controller driver Date: Tue, 22 Dec 2015 00:04:22 +0100 Message-ID: <201512220004.22548.arnd@arndb.de> References: <1450442339-18765-4-git-send-email-stanimir.varbanov@linaro.org> <201512182111.1GLn2hxy%fengguang.wu@intel.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Return-path: Received: from mout.kundenserver.de ([217.72.192.75]:52557 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751598AbbLUXFk (ORCPT ); Mon, 21 Dec 2015 18:05:40 -0500 In-Reply-To: Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Bjorn Andersson Cc: kbuild test robot , Stanimir Varbanov , kbuild-all@01.org, linux-arm-msm , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" , linux-pci@vger.kernel.org, Bjorn Helgaas , Srinivas Kandagatla , Russell King , Rob Herring , Rob Herring , Mark Rutland , Pawel Moll , Ian Campbell , Jingoo Han , Pratyush Anand , Bjorn Andersson , Stanimir Varbanov On Monday 21 December 2015, Bjorn Andersson wrote: > I disagree with this "recommendation" as it's only outcome will be asymmetry. > > I think this script should be changed to only warn if there's a single > IS_ERR/PTR_ERR at the end of the function, not if there's a list of > them and this would replace the last one. > Agreed, looks like a false positive, and I think it's best to ignore the warning here, but not change the script that seems reasonable in general. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 From: arnd@arndb.de (Arnd Bergmann) Date: Tue, 22 Dec 2015 00:04:22 +0100 Subject: [PATCH v5 3/5] PCI: qcom: Add Qualcomm PCIe controller driver In-Reply-To: References: <1450442339-18765-4-git-send-email-stanimir.varbanov@linaro.org> <201512182111.1GLn2hxy%fengguang.wu@intel.com> Message-ID: <201512220004.22548.arnd@arndb.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Monday 21 December 2015, Bjorn Andersson wrote: > I disagree with this "recommendation" as it's only outcome will be asymmetry. > > I think this script should be changed to only warn if there's a single > IS_ERR/PTR_ERR at the end of the function, not if there's a list of > them and this would replace the last one. > Agreed, looks like a false positive, and I think it's best to ignore the warning here, but not change the script that seems reasonable in general. Arnd