From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752792AbbLVBQi (ORCPT ); Mon, 21 Dec 2015 20:16:38 -0500 Received: from one.firstfloor.org ([193.170.194.197]:37804 "EHLO one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751732AbbLVBQd (ORCPT ); Mon, 21 Dec 2015 20:16:33 -0500 Date: Tue, 22 Dec 2015 02:16:30 +0100 From: Andi Kleen To: Jiri Olsa Cc: Andi Kleen , acme@kernel.org, jolsa@kernel.org, mingo@kernel.org, linux-kernel@vger.kernel.org, Andi Kleen Subject: Re: [PATCH 1/6] perf, tools, stat: Abstract stat metrics printing Message-ID: <20151222011630.GE15533@two.firstfloor.org> References: <1450145059-22547-1-git-send-email-andi@firstfloor.org> <1450145059-22547-2-git-send-email-andi@firstfloor.org> <20151221154232.GA13912@krava.brq.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151221154232.GA13912@krava.brq.redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > - fprintf(out, " "); > > + print_metric(ctxp, NULL, NULL, "insn per cycle", 0); > > } > > total = avg_stats(&runtime_stalled_cycles_front_stats[ctx][cpu]); > > total = max(total, avg_stats(&runtime_stalled_cycles_back_stats[ctx][cpu])); > > > > + out->new_line(ctxp); > > if (total && avg) { > > ratio = total / avg; > > - fprintf(out, "\n"); > > you haven't address my first comment in here http://marc.info/?l=linux-kernel&m=144662610723134&w=2 The new_line is always needed because stalled cycles is always printed. The reason it is always printed is that metric-only needs to see all the metrics for its column headers. That's why there are else cases everywhere. -Andi -- ak@linux.intel.com -- Speaking for myself only.