From: Cyril Bur <cyrilbur@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] linux: Build and install kernel selftests
Date: Tue, 22 Dec 2015 09:18:59 +1100 [thread overview]
Message-ID: <20151222091859.1b3de5c0@camb691> (raw)
In-Reply-To: <20151221092513.GA3454@free.fr>
On Mon, 21 Dec 2015 10:25:13 +0100
"Yann E. MORIN" <yann.morin.1998@free.fr> wrote:
> Cyril, All,
>
> On 2015-12-21 16:44 +1100, Cyril Bur spake thusly:
> > On Thu, 17 Dec 2015 19:07:35 +0100
> > "Yann E. MORIN" <yann.morin.1998@free.fr> wrote:
> > Totally agreed will address everything you mention. I should have mentioned a
> > few in more detail, my bad for not going over it in more detail before posting,
> > you're correct that a few things in there are actually non obvious.
>
> No problem! Things just happen to be obvious when you actually do the
> job, because everything is fresh in your memory. Patch reviews are there
> to eventually highlight that fact. So, really, that's not a problem.
>
> [--SNIP--]
> > > > > > +SELFTESTS_INSTALL_STAGING = YES
> > > > > Why install it in staging?
> > > > I actually hadn't initially but I did get to a point in my work where I had
> > > > to objdump a test binary. So, since I needed it, it stayed.
> > > But can't you objdump the binaries that are installed in target/ instead?
> >
> > I think I tried that initially but IIRC they get stripped when put into target/
> > which proved annoying when objdumping.
>
> But then, the 'original' binaries are still present in the build
> directory, where they are definitely not stripped (at least, not by
> Builroot). Isn't that enough?
>
Doh, you're right of course they'll be in the linux build dir, I'll change that
too - I'll be sure to comment that one, even I totally forgot that haha.
Thanks
> Staging is really for libraries and headers that are to be used by
> another package. Kernel selftests are not headers, they are not
> libraries, so nothing will include/link them. So, I still believe
> there's no reason to put them in staging.
>
> Regards,
> Yann E. MORIN.
>
next prev parent reply other threads:[~2015-12-21 22:18 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-24 23:53 [Buildroot] [PATCH] Add Linux kernel selftests building Cyril Bur
2015-11-24 23:53 ` [Buildroot] [PATCH] linux: Build and install kernel selftests Cyril Bur
2015-12-14 22:18 ` Yann E. MORIN
2015-12-15 6:37 ` Baruch Siach
2015-12-15 17:31 ` Yann E. MORIN
2015-12-17 1:25 ` Cyril Bur
2015-12-17 1:45 ` Cyril Bur
2015-12-17 18:07 ` Yann E. MORIN
2015-12-21 5:44 ` Cyril Bur
2015-12-21 9:25 ` Yann E. MORIN
2015-12-21 22:18 ` Cyril Bur [this message]
2015-12-21 22:25 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151222091859.1b3de5c0@camb691 \
--to=cyrilbur@gmail.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.