From: Will Deacon <will.deacon@arm.com>
To: Andre Przywara <andre.przywara@arm.com>
Cc: dimitri.j.ledkov@intel.com, sasha.levin@oracle.com,
penberg@kernel.org, kvmarm@lists.cs.columbia.edu,
kvm@vger.kernel.org
Subject: Re: [PATCH 1/2] Add a rudimentary manpage
Date: Tue, 22 Dec 2015 15:11:13 +0000 [thread overview]
Message-ID: <20151222151113.GI32623@arm.com> (raw)
In-Reply-To: <1450792847-1783-2-git-send-email-andre.przywara@arm.com>
Hi Andre, of Phoronix fame,
On Tue, Dec 22, 2015 at 02:00:46PM +0000, Andre Przywara wrote:
> The kvmtool documentation is somewhat lacking, also it is not easily
> accessible when living in the source tree only.
> Add a good ol' manpage to document at least the basic commands and
> their options.
> This level of documentation matches the one that is already there in
> the Documentation directory and should be subject to extension.
>
> Signed-off-by: Andre Przywara <andre.przywara@arm.com>
> ---
> Documentation/kvmtool.1 | 222 ++++++++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 222 insertions(+)
> create mode 100644 Documentation/kvmtool.1
>
> diff --git a/Documentation/kvmtool.1 b/Documentation/kvmtool.1
> new file mode 100644
> index 0000000..aecb2dc
> --- /dev/null
> +++ b/Documentation/kvmtool.1
> @@ -0,0 +1,222 @@
> +.\" Manpage for kvmtool
> +.\" Copyright (C) 2015 by Andre Przywara <andre.przywara@arm.com>
> +.TH kvmtool 1 "11 Nov 2015" "0.1" "kvmtool man page"
> +.SH NAME
> +kvmtool \- running KVM guests
> +.SH SYNOPSIS
> +lkvm COMMAND [ARGS]
> +.SH DESCRIPTION
> +kvmtool is a userland tool for creating and controlling KVM guests.
> +.SH "KVMTOOL COMMANDS"
> +.sp
> +.PP
> +.B run -k <kernel-image> ...
You seem to be inconsistent with your synopses for each command. That is,
here you just have -k <kernel-image> ... , but later you have things like
> +.B debug --all|--name <guest name> [--dump] [--nmi <n>] [--sysrq <rq>]
which describes all of the possible options to debug. I think I prefer
this latter way, so could you make all of the commands look like that,
please?
Will
next prev parent reply other threads:[~2015-12-22 15:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-22 14:00 [PATCH 0/2] kvmtool: replace documentations stubs with manpage Andre Przywara
2015-12-22 14:00 ` [PATCH 1/2] Add a rudimentary manpage Andre Przywara
2015-12-22 15:11 ` Will Deacon [this message]
2015-12-22 14:00 ` [PATCH 2/2] Documentation: remove documentation stubs and common-cmds.h generation Andre Przywara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151222151113.GI32623@arm.com \
--to=will.deacon@arm.com \
--cc=andre.przywara@arm.com \
--cc=dimitri.j.ledkov@intel.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=penberg@kernel.org \
--cc=sasha.levin@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.