From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peng Fan Date: Wed, 23 Dec 2015 11:07:23 +0800 Subject: [U-Boot] [PATCH 1/1] common: env: initialize scalar variable In-Reply-To: <20151222092951.D2F8C383C2A@gemini.denx.de> References: <1450775655-2979-1-git-send-email-van.freenix@gmail.com> <1450775655-2979-2-git-send-email-van.freenix@gmail.com> <20151222092951.D2F8C383C2A@gemini.denx.de> Message-ID: <20151223030722.GB24788@linux-7smt.suse> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Wolfgang On Tue, Dec 22, 2015 at 10:29:51AM +0100, Wolfgang Denk wrote: >Dear Peng Fan, > >In message <1450775655-2979-2-git-send-email-van.freenix@gmail.com> you wrote: >> From: Peng Fan >> >> Before calling hsearch_r, initialize callback entry to NULL. > >Which exact problem are you fixing here? This was reported by Coverity. " Uninitialized scalar variable (UNINIT) uninit_use_in_call: Using uninitialized value e. Field e.callback is uninitialized when calling hsearch_r. " I'll add more commit log in V2. Regards, Peng. > >Best regards, > >Wolfgang Denk > >-- >DENX Software Engineering GmbH, Managing Director: Wolfgang Denk >HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany >Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de >Beware of the Turing Tar-pit in which everything is possible but >nothing of interest is easy.