From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35541) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aBdu7-0008CZ-Oe for qemu-devel@nongnu.org; Wed, 23 Dec 2015 02:32:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aBdu3-0002sy-OD for qemu-devel@nongnu.org; Wed, 23 Dec 2015 02:32:11 -0500 Received: from mx1.redhat.com ([209.132.183.28]:45401) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aBdu3-0002ri-Im for qemu-devel@nongnu.org; Wed, 23 Dec 2015 02:32:07 -0500 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id 4C8C58E23B for ; Wed, 23 Dec 2015 07:32:06 +0000 (UTC) Date: Wed, 23 Dec 2015 15:32:01 +0800 From: Fam Zheng Message-ID: <20151223073201.GG14423@ad.usersys.redhat.com> References: <1450744268-25052-1-git-send-email-eblake@redhat.com> <1450744268-25052-5-git-send-email-eblake@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1450744268-25052-5-git-send-email-eblake@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2 04/14] qapi: Factor out JSON number formatting List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: pbonzini@redhat.com, Luiz Capitulino , qemu-devel@nongnu.org, armbru@redhat.com On Mon, 12/21 17:30, Eric Blake wrote: > Pull out a new qstring_append_json_number() helper, so that all > JSON output producers can use a consistent style for printing > floating point without duplicating code (since we are doing more > data massaging than a simple printf format can handle). > > Address one FIXME by adding an Error parameter and warning the > caller if the requested number cannot be represented in JSON; > but add another FIXME in its place because we have no way to > report the problem higher up the stack. > > Signed-off-by: Eric Blake Reviewed-by: Fam Zheng