All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexander Aring <alex.aring@gmail.com>
To: Brad Campbell <bradjc5@gmail.com>
Cc: Varka Bhadram <varkabhadram@gmail.com>, linux-wpan@vger.kernel.org
Subject: Re: [PATCH v2 0/1] ieee802154: cc2520: Check CRC & add promiscuous
Date: Wed, 23 Dec 2015 10:22:29 +0100	[thread overview]
Message-ID: <20151223092213.GA2075@omega> (raw)
In-Reply-To: <1450858678-59333-1-git-send-email-bradjc5@gmail.com>

On Wed, Dec 23, 2015 at 03:17:57AM -0500, Brad Campbell wrote:
> I've updated the patch to provide monitors a method for determining if
> the incoming packet had a valid CRC or not. This required adding promiscuous
> mode, which is no longer the default.
> 
> Also, am I correct in noting that configuring a node interface to be in
> promiscuous mode with something like:
> 
> ioctl(sockfd, SIOCGIFFLAGS, &ifopts);
> ifopts.ifr_flags |= IFF_PROMISC;
> ioctl(sockfd, SIOCSIFFLAGS, &ifopts);
> 
> is not currently supported? That's how I was testing at first and it
> didn't seem to work.... Also, if a user does set an interface to
> promiscuous using an ioctl, it seems like they would still want CRC
> checking, which is not what would currently happen.
> 

These flags does nothing, like in wireless we need to create a special
interface type for starting in promiscuous mode. Try [0].

The receiving path and the reason that monitors has no addresses is why
we handle it in that way.

All "NODE" types need to be parsed again on 802.15.4 conform header and
doing address filtering/etc stuff again. This is different on "MONITOR"
types, we parse nothing and this goes directly into userspace, the PHR
header (the len field) is the only thing which we should filter and
mostly in-driver because after frame[len] there is much moslty some
data (lqi/rssi/etc).


When you sniff on normal "NODE" type, then you will sniff with transceiver
filtering stuff enabled (address filtering/frame/etc.) what the
transceiver does AND what mac802154 does.

- Alex

[0] http://wpan.cakelab.org/#_sniffing

  parent reply	other threads:[~2015-12-23  9:22 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-23  8:17 [PATCH v2 0/1] ieee802154: cc2520: Check CRC & add promiscuous Brad Campbell
2015-12-23  8:17 ` [PATCH v2 1/1] " Brad Campbell
2015-12-23  9:55   ` Alexander Aring
2015-12-23 21:27     ` Brad Campbell
2015-12-23 22:12       ` Alexander Aring
2015-12-23  9:22 ` Alexander Aring [this message]
2015-12-23 21:33   ` [PATCH v2 0/1] " Brad Campbell
2015-12-23 22:17     ` Alexander Aring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151223092213.GA2075@omega \
    --to=alex.aring@gmail.com \
    --cc=bradjc5@gmail.com \
    --cc=linux-wpan@vger.kernel.org \
    --cc=varkabhadram@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.