All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Shivani Bhardwaj <shivanib134@gmail.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] extensions: libxt_NFLOG: Add group_info and remove multiple keywords
Date: Wed, 23 Dec 2015 11:13:33 +0100	[thread overview]
Message-ID: <20151223101333.GA3026@salvia> (raw)
In-Reply-To: <20151222200246.GA11677@gmail.com>

On Wed, Dec 23, 2015 at 01:32:46AM +0530, Shivani Bhardwaj wrote:
> Add group_info with every rule as it is mandatory to consider logging to
> be same type as NFLOG.
> Remove multiple log keywords to avoid loading multiple log expressions
> at a time.
> 
> Examples:
> 
> $ sudo iptables-translate -I INPUT -j NFLOG --nflog-threshold 2
> nft insert rule ip filter INPUT counter log queue-threshold 2 group 0
> 
> $ sudo iptables-translate -A FORWARD -j NFLOG --nflog-group 32 --nflog-prefix "Prefix 1.0"
> nft add rule ip filter FORWARD counter log prefix \"Prefix 1.0\" group 32

Applied, thanks Shivani.

BTW, it's a good practise to credit people that report problems, ie.
add this tag:

Reported-by: Arturo Borrero <arturoborreroglez@gmail.com>

> Signed-off-by: Shivani Bhardwaj <shivanib134@gmail.com>


  reply	other threads:[~2015-12-23 10:13 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-22 20:02 [PATCH] extensions: libxt_NFLOG: Add group_info and remove multiple keywords Shivani Bhardwaj
2015-12-23 10:13 ` Pablo Neira Ayuso [this message]
2015-12-23 10:14   ` Shivani Bhardwaj

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151223101333.GA3026@salvia \
    --to=pablo@netfilter.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=shivanib134@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.