From: Matt Fleming <matt@codeblueprint.co.uk>
To: "Elliott, Robert (Persistent Memory)" <elliott@hpe.com>
Cc: "tglx@linutronix.de" <tglx@linutronix.de>,
"mingo@redhat.com" <mingo@redhat.com>,
"hpa@zytor.com" <hpa@zytor.com>,
"x86@kernel.org" <x86@kernel.org>,
"linux-efi@vger.kernel.org" <linux-efi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/4] x86/efi: show actual ending addresses in efi_print_memmap
Date: Wed, 23 Dec 2015 12:44:39 +0000 [thread overview]
Message-ID: <20151223124439.GA2471@codeblueprint.co.uk> (raw)
In-Reply-To: <94D0CD8314A33A4D9D801C0FE68B40295BEC74CF@G9W0745.americas.hpqcorp.net>
On Tue, 22 Dec, at 08:08:19PM, Elliott, Robert (Persistent Memory) wrote:
>
> While investigating the grub persistent memory corruption
> issues, it was helpful to make this table match the ending
> address convention used by:
> * the kernel's e820 table prints
> * the kernel's nosave memory prints
> * grub's lsmmap and lsefimmap commands
> * the UEFI shell's memmap command
>
> Using the excerpts from the patch, if you grep all the various
> logs for c7fffffff, you won't find the line with c80000000.
I like this. This is reasonable justification. Please inclue it in the
commit log.
next prev parent reply other threads:[~2015-12-23 12:44 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-18 1:28 (unknown), Robert Elliott
2015-12-18 1:28 ` [PATCH 1/4] x86/efi: show actual ending addresses in efi_print_memmap Robert Elliott
2015-12-21 15:50 ` Matt Fleming
[not found] ` <20151221155038.GD4227-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>
2015-12-21 16:06 ` Matt Fleming
[not found] ` <20151221160629.GF4227-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>
2015-12-22 20:08 ` Elliott, Robert (Persistent Memory)
2015-12-23 12:44 ` Matt Fleming [this message]
2015-12-21 16:44 ` Elliott, Robert (Persistent Memory)
[not found] ` <94D0CD8314A33A4D9D801C0FE68B40295BEC3C9C-W1gbDvblbosSZAcGdq5asR6epYMZPwEe5NbjCUgZEJk@public.gmane.org>
2015-12-23 12:47 ` Matt Fleming
[not found] ` <20151223124711.GB2471-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>
2015-12-24 1:07 ` [PATCH v2 " Robert Elliott
2016-01-08 12:04 ` Matt Fleming
2015-12-18 1:28 ` [PATCH 2/4] efi: add NV memory attribute Robert Elliott
[not found] ` <1450402114-3606-3-git-send-email-elliott-ZPxbGqLxI0U@public.gmane.org>
2015-12-21 15:54 ` Matt Fleming
2015-12-18 1:28 ` [PATCH 3/4] efi: add Persistent Memory type name Robert Elliott
[not found] ` <1450402114-3606-4-git-send-email-elliott-ZPxbGqLxI0U@public.gmane.org>
2016-01-08 12:20 ` Matt Fleming
[not found] ` <1450402114-3606-1-git-send-email-elliott-ZPxbGqLxI0U@public.gmane.org>
2015-12-18 1:28 ` [PATCH 4/4] x86/efi: print size and base in binary units in efi_print_memmap Robert Elliott
[not found] ` <1450402114-3606-5-git-send-email-elliott-ZPxbGqLxI0U@public.gmane.org>
2015-12-21 16:16 ` Matt Fleming
[not found] ` <20151221161629.GG4227-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>
2015-12-23 0:11 ` Elliott, Robert (Persistent Memory)
[not found] ` <94D0CD8314A33A4D9D801C0FE68B40295BEC79CB-W1gbDvblbosSZAcGdq5asR6epYMZPwEe5NbjCUgZEJk@public.gmane.org>
2015-12-23 15:52 ` Matt Fleming
2015-12-27 14:35 ` Andy Shevchenko
2016-01-08 12:19 ` Matt Fleming
[not found] ` <20160108121921.GI2532-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>
2016-01-08 16:38 ` Elliott, Robert (Persistent Memory)
2016-01-08 16:44 ` Andy Shevchenko
2016-01-08 16:39 ` Andy Shevchenko
2016-01-11 14:09 ` Matt Fleming
[not found] ` <20160111140915.GB2644-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>
2016-01-12 13:17 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151223124439.GA2471@codeblueprint.co.uk \
--to=matt@codeblueprint.co.uk \
--cc=elliott@hpe.com \
--cc=hpa@zytor.com \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.